[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libphp-simplepie



Chris Lamb wrote:
> http://mentors.debian.net/debian/pool/main/l/libphp-simplepie/libphp-simplepie_1.0beta3.2-1.dsc

  * should: please mention the reason for the action you did in
    README.Debian

  * should: mention the repackaging in copyright, not in
    README.Debian-source

  * tipp: remove the useless empty line at the end of the
    changelog file.

  * wondering: why do you prefere php4 over php5 in the
    depends/recommends?

  * should: the Homepage entry in control should have
    two leading spaces.

  * must: your copyright is incomplete, there are other files with
    different copyright holders.

  * tipp: dirs is not required as you copy the files with a install file

  * tipp: do not prefix some helper files and some not when you have
    only a one-binary package.

  * tipp: remove the useless commented things in the watch file.

if you fix above things, i'm happy to sponsor it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/



Reply to: