Re: RFS: jlha-utils -- command-line lzh archiver written in Java

[Daniel Baumann <daniel@debian.org>]

Ying-Chun Liu (PaulLiu) wrote:
> http://mentors.debian.net/debian/pool/main/j/jlha-utils/jlha-utils_0.1.3-3.dsc

given that you are upstream, please fix your tarballs. they should
extract to a new directory (e.g. ${package}-${version}) and *not* to the
current directory.

  * in README.Debian, this:
-- Ying-Chun Liu (PaulLiu) <grandpaul@gmail.com>, Tue,  8 Aug 2006
23:12:38 +0800

    should be this:
-- Ying-Chun Liu (PaulLiu) <grandpaul@gmail.com>  Tue,  8 Aug 2006
23:12:38 +0800

    Note the replaced colon with a space.

  * changelog has a useless empty line at the end of the file.

  * merge all revisions together, so that -1 will be the first upload to
    debian.

  * README doesn't provide any new information what is not already
    included in README.Debian. drop the one or the other.

  * remove the empty lines at the end of the sgml file and rules.

  * hint: if you use install -D, you don't need *.dirs anymore

  * for consistency reasons: your package build only one binary-package.
    nevertheless, you have some prefixed helpers (e.g. jlha-utils.p*)
    and some non prefixed helpers (e.g. docs). don't mix this,
    either prefix all helpers with the package name, or do not
    prefix anything.

if you fixed the things above, i'll look again at the package and, if
good, upload it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/