[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: kallery - Image gallery generator for the KDE



Marvin Stark wrote:
> http://stuff.der-marv.de/debian/kallery/1.2.0-1/

  * you should build-depend on -dev library packages, not the library
    itself.

  * Instead of just writing '  http://kallery.kdewebdev.org/', you may
    want to use the more common
    '  Homepage: http://kallery.kdewebdev.org/'.

  * there are files under other license than GPL in your orig.tar.gz

  * README does not contain any usefull information

  * how about adding a desktop file?

  * the package doesn't build, because chrpath cannot be found.
    unrelated to that, instead of chrpath you can pass --disable-rpath
    to configure.

  * why dh_makeshlibs?

if you fix above issues, i'll look again at it and, if good, sponsor it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/



Reply to: