[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sonata - GTK+ client for the Music Player Daemon



Michal C(ihar( wrote:
> dget http://mentors.debian.net/debian/pool/main/s/sonata/sonata_0.8.1-1.dsc

besides that above is not true, it's -2 instead:

  * changelog has a useless empty line at the end.

  * note that it doesn't make sens to bump the revision, when the
    previous wasn't uploaded to debian - just merge them.

  * Standards-Version: 3.7.2.1 is over-precise,
    Standards-Version: 3.7.2 is just enough.

  * dirs is useless here, the build system just creates the directory on
    its own.

  * you install README within docs, but it doesn't contain any usefull
    information.

  * don't use two or more lines as seperator in rules, one is just
    enough.

the rest is good, if you fix above things, i'll upload it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/



Reply to: