Re: RFS: dnshistory

[Daniel Baumann <daniel@debian.org>]

Matthias Julius wrote:
> - dget http://mentors.debian.net/debian/pool/main/d/dnshistory/dnshistory_1.2-1.dsc

please fix the following things:

  * remove the useless empty line at the end of changelog.

  * ${misc:Depends} is useless here

  * this:

---snip---
 Homepage: http://www.stedee.id.au/dnshistory/
---snap---

   should be this:

---snip---
  Homepage: http://www.stedee.id.au/dnshistory/
---snap---

   note the two leading speaces before homepage.

  * debian/dirs is useless, the build system just creates
    the directory on its own.

  * cleanup postinst/postrm:

    - remove the useless commented things
    - remove the empty lines at the end of the files

  * cleanup rules:

    - remove the useless commented things
    - don't use two empty lines as seperator, one is just enough.
    - you should update config.sub/config.guess within clean:,
      look at libextractor on how to do it.
    - dh_installman is useless, remove it.

  * remove the useless commented things in watch

if you fix above things, i'm happy to sponsor it.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/