Re: RFS: harminv
On Sat, Nov 11, 2006 at 07:36:42PM +0100, Loïc Le Guyader wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "harminv".
IANADD, so I can't sponsor, but I have reviewed your package and have
the following comments:
$ lintian -I
W: libharminv: non-dev-pkg-with-shlib-symlink usr/lib/libharminv.so.2.0.4 usr/lib/libharminv.so
You need to move the libharmin.so symlink to the -dev package, as it
is only used when developing with the library and not at runtime.
related to this:
$dpkg --contents /var/cache/pbuilder/result/libharminv_1.3.1-1_i386.deb
-rw-r--r-- root/root 479 2006-11-11 13:57 ./usr/lib/pkgconfig/harminv.pc
-rw-r--r-- root/root 1061 2006-11-11 13:57 ./usr/lib/libharminv.la
-rw-r--r-- root/root 21314 2006-11-11 13:57 ./usr/lib/libharminv.a
Those files belong in the -dev package, too. And, unless you know
there's specific reason, you should not even ship the .la and .a
files. The *pc file replaces the *la in a better way. The *.a file is
only needed for static linking, which is frowned upon.
W: libharminv: package-name-doesnt-match-sonames libharminv2
Your library package should be called libharminv2, so that different
versions of the library can coexist in the system.
For both messages, read extra explanations in
http://www.netfort.gr.jp/~dancer/column/libpkg-guide/libpkg-guide.html
I: harminv: hyphen-used-as-minus-sign usr/share/man/man1/harminv.1.gz:57
I: harminv: hyphen-used-as-minus-sign usr/share/man/man1/harminv.1.gz:67
I: harminv: hyphen-used-as-minus-sign usr/share/man/man1/harminv.1.gz:69
I: harminv: hyphen-used-as-minus-sign usr/share/man/man1/harminv.1.gz:89
I: harminv: hyphen-used-as-minus-sign usr/share/man/man1/harminv.1.gz:180
Minor bugs: Run lintian with -i to get a detailed explanation. Submitt
this changes upstream, they're bugs there, too.
$ dpkg --info /var/cache/pbuilder/result/libharminv-dev_1.3.1-1_all.deb
[...]
Package: libharminv-dev
Version: 1.3.1-1
Section: libdevel
Priority: optional
Architecture: all
Depends: libharminv
I believe the -dev package should depend on libharminv (= ${Source:version})
I did no review of your debian/copyright file, so there might be
issues with it.
I wish you good luck in finding a sponsor.
Reply to: