[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: lisaac



Hi Frédéric,
I'm not a DD (so I can't upload, and for sure I'll miss some notes),
but I gave a look at your package and found some issues:

* lintian errors:
E: lisaac-doc: copyright-should-refer-to-common-license-file-for-gpl
E: lisaac-common: copyright-should-refer-to-common-license-file-for-gpl
E: lisaac: copyright-should-refer-to-common-license-file-for-gpl

you have to correct them; use lintian -iv <somewhere>.changes to find
all lintian complains and their extended description.

* compat: why it's 4 and not 5 (last version of compatibility)? this
requires to set dependecy on debhelper (>=5)

* debian/watch: remove all indication on how to use the file from the
dh-template, leaving only the relevant lines

* debian/control: why not adding "Homepage:" meta-tag?

* your name: I suggest to use only one way to write your name (I love
uniformity); debian/{changelog,control,copyright} use one way, but
lisaac.1 has a different one. In addiction, just for clarification,
the email address from where you've sent this email is different from
the one used in the package: is one an alias for the other?

* debian/rules: remove header from dh-make template; remove commended
dh_* calls from build-common target

* instead of modifying upstream code, it's better if you use a
patch-system, like dpatch or quilt to modify the source code at
buildtime (path.li is the reason for this advertise).

Kind Regards,
Sandro

--
Sandro Tosi (aka Morpheus, matrixhasu)
My (little) site: http://matrixhasu.altervista.org/



Reply to: