[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] listen - A nice music player and manager for GNOME

On Tuesday 15 August 2006 23:38, Julien Valroff wrote:
> Le mardi 15 août 2006 à 20:13 +0200, Christoph Haas a écrit :
> > On Sunday 13 August 2006 13:51, Julien Valroff wrote:
> > > I am looking for a sponsor to upload the listen package.
> > > [...]
> > > I would be happy to receive your comments.
> >
> > The package looks good to me although I don't speak CDBS. I just
> > wonder why there is no menu item showing up in KDE although a
> > listen.desktop file is shipped. You also don't provide a 'menu' file
> > so on KDE here there is no way to start the application without a
> > shell.
> I do not use KDE, but the .desktop file shipped in the upstream tarball
> works on GNOME. I have improved it following Free Desktop's Desktop
> Entry Specification[1] and Desktop Menu Specification[2]. I used a patch
> for that.

Looks reasonable. Although I probably hadn't changed the description 
strings myself in a patch.

> May you please check if it is ok on KDE?

Perfect. Menu item present on KDE.

> Thanks, I totally forgot to include a menu entry, which is now done. I
> had to add a build-dependency on imagemagick to convert the PNG icon to
> an XPM icon.

Since it's just a build-time dependency that's surely okay.

Works nice. Uploaded. Let me know if you need subsequent sponsorship.

".signature" [Modified] 1 line --100%--                1,48         All

Reply to: