[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: xshisen_1.51-2 --- Shisen-sho game for X11



On 2/10/06, Zak B. Elep <zakame@spunge.org> wrote:
> As usual the source package can be found at mentors.debian.net .[1]
> [1]  http://mentors.debian.net/debian/pool/main/x/xshisen/

Zak, I've been looking at the package.  It looks quite good.

However, I found that at the changelog you close many bugs,
acknowledging the NMUs.  This is what the Developer's Reference says,
but it has actually been reported as a bug, by Jeroen [1].  So, you
might want to drop that and ask your future sponsor to please build
the package with the -v<version> option.

[1]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=353447

Also, I got all these lintian errors:

W: xshisen: manpage-has-errors-from-man
usr/share/man/man6/xshisen.6.gz 140: a space character is not allowed
in an escape name
W: xshisen: manpage-has-errors-from-man
usr/share/man/ja/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot
adjust line
W: xshisen: manpage-has-errors-from-man
usr/share/man/ja_JP/man6/xshisen.6.gz 9: warning [p 1, 2.0i]: cannot
adjust line
W: xshisen: manpage-has-errors-from-man
usr/share/man/ja_JP.JIS7/man6/xshisen.6.gz  conversion from `JIS7' is
not supported
W: xshisen: manpage-has-errors-from-man
usr/share/man/ja_JP.PCK/man6/xshisen.6.gz  conversion from `PCK' is
not supported
W: xshisen: manpage-has-errors-from-man
usr/share/man/ja_JP.SJIS/man6/xshisen.6.gz 9: warning [p 1, 2.0i]:
cannot adjust line
W: xshisen: manpage-has-errors-from-man
usr/share/man/ja_JP.eucJP/man6/xshisen.6.gz 9: warning [p 1, 2.0i]:
cannot adjust line
W: xshisen: manpage-has-errors-from-man
usr/share/man/ja_JP.ujis/man6/xshisen.6.gz 9: warning [p 1, 2.0i]:
cannot adjust line
W: xshisen: unquoted-string-in-menu-item /usr/share/menu/xshisen needs:2
W: xshisen: unquoted-string-in-menu-item /usr/share/menu/xshisen section:2

The manpages might not be errors at all, since it's in japanese, and
maybe lintian is not really so good at checking japanese manpages, but
the others are real warnings:

?package(xshisen):needs=X11 section=Games/Board\
  title="xshisen" command="/usr/games/xshisen"

Should be:

?package(xshisen):needs="X11" section="Games/Board"\
  title="xshisen" command="/usr/games/xshisen"

Also, when running "linda" against it, I got this other error:

W: xshisen; Package version 1.51-2 is less than 1.51-1-1.3.

Which looks kind of puzzling at the first moment, but after parsing
the numbers, it's correct.

1.51-2 means: upstream 1.51 - debian 2
1.51-1-1.3 means: upstream 1.51-1 - debian 1.3

So, even if the debian part is greater, the upstream part is smaller. 
I guess you'll have to keep the extra -1 until the next upstream
release comes.

--
Besos,
Marga



Reply to: