[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: fhist -- File history, comparison and merge utilities



On Thu, Nov 17, 2005 at 10:18:59AM +0100, Christopher Sch?tz wrote:
> Package:	fhist
> Version:	1.15-1
> Author:		Peter Miller
> License:	GPL
> ITA:		279516
> 
> Description: File history, comparison and merge utilities
>  The fhist package contains 3 utilities
>    fhist - a file history tool
>    fcomp - a file comparison tool
>    fmerge - a file merging tool
>  .
>  All three are bundled together, because they all
>  use the same minimal-difference algorithm.
> 
> Homepage:	http://fhist.sourceforge.net/fhist.html
> 
> Packages:	http://rcswww.urz.tu-dresden.de/~s2055530/fhist/
  --- fhist-1.15.orig/debian/dirs
  +++ fhist-1.15/debian/dirs
  @@ -0,0 +1,4 @@
  +usr/bin
  +usr/man/man1
  +usr/share/fhist/en/man1
  +usr/share/fhist/en/LC_MESSAGES

The manpages should be installed in /usr/share/man/.  I see that you
are rm -fr some stuff (legitimate) in the clean target after making
these directories.  Does the upstream build system not make the
directories it requires?

You shouldn't need to use both ./debian/dirs and 
+	install -d debian/fhist-doc/usr/share/doc/fhist-doc
+	install -d debian/fhist/usr/share/man/man1

  --- fhist-1.15.orig/debian/rules
  +++ fhist-1.15/debian/rules
  +source diff:
  +	@echo >&2 'source and diff are obsolete - use dpkg-source -b'; false

This doesn't appear to be used; where did it come from, anyway?  If
they serve a purpose, they should probably be listed in .PHONY, for
consistency and transparency.

  --- fhist-1.15.orig/debian/docs
  +++ fhist-1.15/debian/docs
  @@ -0,0 +1 @@
  +README 

You might prefer passing README on the commandline to dh_installdocs
rather than using a separate file.

  fhist-1.15/debian/rules and
  fhist-1.15/debian/copyright

Please consider adding a sentence to both files to the effect of
"modifications since 2005 are a work of Christopher Schuetz, and are
hereby published under the LICENSE license." (Or "copyright" if its
not public domain).  You should add your own name to the copyright
file, too.

Sorry but I can't yet sponsor packages.

-- 
Clear skies,
Justin



Reply to: