tor, 09 06 2005 kl. 16:23 +0200, skrev Sven Mueller:
> > Package Name: em-panel-applet
> > Version: 0.2-1
> > Upstream Author: Miguel Angel Lopez Hernandez <miguel@gulev.org.mx>
> > License: GPL
> > Description: Mail noficiation applet for Evolution
> > Source and i386 binary packages can be found at
> > http://www.warma.dk/ubuntu/em-panel-applet/
> Note that I can't sponsor anyway as IANADD, but I just took a look at
> the diff.gz file only and noticed a few things:
>
> debian/README.Debian
>
> - You should either edit that and add Debian-specific notes to it or
> remove it completely.
Good point!
> debian/copyright:
>
> - The license is GPL, the copyright is "Copyright 2005 Novell, Inc.",
> you said the opposite.
Not understood. Miguel wrote it, passed the copyright to Novell and the
license is GPL. What am I doing wrong then?
> - Also the GPL version 2 is available on Debian systems under
> /usr/share/common-licenses/GPL-2 and you should state that in the
> opyright file.
Check.
> debian/rules:
> - You added a line with docbook-to-man to the build-stamp target, but
> commented it out. Why?
> - You should remove, not only comment-out unneeded dh_* calls
I used dh_make to make the debian directory including the rules file,
and dh_make puts all of those in. That's why they're there. I'll remove
them.
> Did you remove config.sub/config.guess from the upstream tarball or
> didn't it contain those from the beginning?
They weren't there.
> W: em-panel-applet; File /usr/share/doc/em-panel-applet/NEWS.gz in
> package has zero size.
> The file above has a size of zero, which probably means it shouldn't
> be installed.
> ***** So you added a NEWS file, but didn't fill it with anything. Either
> ***** remove it or add content.
No, actually, the NEWS file was in the upstream, but empty. Just like
README, AUTHORS and ChangeLog. I'll remove them, no problem.
> Same again (changelog.gz should contain upstream changelog)
Exactly. :-)
> E: em-panel-applet; Binary /usr/bin/em-panel-applet contains unneeded
> section .comment.
> This binary or shared library is not completely stripped. It contains
> the unneeded section .note, or .comment.
Hmm... I may have compiled it with nostrip and debug options.
Whoops. :-)
> E: em-panel-applet; Binary /usr/bin/em-panel-applet is not stripped.
> The binary shown is not stripped, and is included in a standard
> package, while Policy shows that it should be stripped.
> ***** Forgot to strip the binary ("strip em-panel-applet")
dh_strip does that, right?
> lintian also finds these additional ones:
Weirdness. When I ran lintian, it was totally quiet..
Thanks for all you excellent input.
--
Søren Hansen <sh@warma.dk>
Attachment:
smime.p7s
Description: S/MIME cryptographic signature