[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: md5deep



Niall Sheridan wrote on 18/05/2005 00:23:

> I'm looking for a sponsor (and feedback!) for `md5deep' (ITP: #309497).
> The source package is available at: http://niall.evil.ie/debian/md5deep/

I can't sponsor, but here's my feedback:

- (matter of taste) I dislike cdbs because I don't see what debian/rules
   actually does to create the package.
- Patch to upstream makefile creates these lines:
  BIN = $(DESTDIR)/$(PREFIX)/bin
  MAN = $(DESTDIR)/$(PREFIX)/share/man/man1
  The / between $(DESTDIR) and $(PREFIX) is unneeded, since $(PREFIX)
  already starts with a slash.
- somewhat related to the first feedback: You do pass /usr as PREFIX to
  the (patched) upstream makefile, right?

cu,
Sven

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: