[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: xdrawchem

Am Donnerstag, den 24.03.2005, 17:01 +0800 schrieb Li Daobing: 
> Hello,
>    I did a NMU to xdrawchem.
>    The last update date is `7 Aug 2004', and there are some new versions
> in upstream, so I do this update.
>    pbuilder clean.
>    lintian not clean(there is CVS directory in upstream tarball, and I
> don't know how to deal with it).

Normally, you can remove them before running dh_make.

>    linda clean.
>    maint-guide 9.6 clean.
> you can got the package from: http://mentors.debian.net/

Some advices:

You can ease your rules file (you use compat level 4 by default) by
using the whole bunch of dh_* scripts. In every case you should update
config.guess and config.sub with the files provided by the autotools
package (see /usr/share/doc/autotools-dev/README.Debian.gz).

AFAIK the *.moc.cpp files are not removed during the make distclean step
(maybe this information is old, but better control it).

You break documentation (Help > Manual) by
moving /usr/share/xdrawchem/doc to /usr/share/doc/xdrawchem/html without
adding a symlink /usr/share/xdrawchem/doc which points to the new
location. An alternative is to patch the source (search for RingDir and
index.html: xdrawchem/application.cpp:1539) to point to the new
location. AFAIK this is the same bug as in the current official Debian

The .txt files (GPL, COPYRIGHT and HISTORY) are doubled
in /usr/share/doc/xdrawchem and /usr/share/doc/xdrawchem/html and they
are obsolete for /usr/share/doc/xdrawchem:

GPL.txt: /usr/share/common-licenses/GPL contains the latest version of
the GNU GPL and this is mentioned in debian/copyright
COPYRIGHT.txt: The information should be in debian/copyright
HISTORY.txt: is the upstream changelog and you provide it also as

The second problem with these files is, that they become gzipped by
dh_installdocs, but the integrated browser (in xdrawchem) can only
read .html and .txt files. So you should avoid this
for /usr/share/doc/xdrawchem/html. An additional idea to GPL.txt: make
it a symlink to /usr/share/common-licenses/GPL-2. This should work.

Bryan sometimes forgets to update doc/HISTORY.txt. Update it with the
one in the source directory.

And one additional thing you could add, is a doc-base entry, because you
provide a manual with the package. But this is additional stuff.

PS: My own xdrawchem packages are under

Maybe you have additional ideas or another opinion about something you
want to discuss.

Regards, Daniel

Reply to: