[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: balance -- userland tcp proxy with failover



Hi.

Your package is no Debian native package (as you correctly denoted by the -1 on the debian version number). So your source package should consist of the original source archive as provided by upstream (link or rename the upstream tar archive to balance_3.19.orig.tar.gz in the directory above the unpacked source tree).

Also, there seems to be a typo (or something similar to a typo) in the manpage:

From the examples:

       $  balance  8888  localhost::12  !  localhost::4  ! localhost::2
       localhost::2 ! localhost:25
              This  is a simple test, forming 5 groups where balance is
              self referencing 22 its own services 22  times.  This  is
              simply a test which definitely can be tried at home.

The "22" occurences do not really make sense to me. It's listening on port 8888, forwarding it to itself up to 20 times on Port 8888 (first 4 groups: 12+4+2+2=20) and the 21st connection is forwarded to port 24 on localhost.

And you should probably go through your debian/rules file and eliminate the unneeded dh_* calls. dh_installexamples is one example for such unneeded calls, you don't specify any example file on the command line and you also don't have a debian/examples or debian/<package>.examples file which might list such examples. Do I need to list any more examples? (SCNR) You shouldn't keep the dh_* calls you commented out. (They are unused, so why should they even be in the debian/rules file?)

Your email-address in debian/changelog isn't complete

That put aside, your package now looks good to me.

cu,
sven



Reply to: