[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: vhcs (Bug#283005)



On Friday 07 Jan 2005 10:30, Hendrik Frenzel wrote:
> Hi,
>
> I want to release the VHCS packages (Bug#283005) so I'm searching for a
> sponsor. I've build some packages which can be found at
> http://apt.scunc.it/pool/main/sarge/v/vhcs/

OK, I just installed your packages on top of a clean sarge system.

A few issues:

Why is vhcs2-depends a contrib package? What is vhcs2-depends for? I just did 
apt-get install vhcs.

courier-base asks a debconf question about creating directories for web 
administration. Do I answer yes or no or does it not matter?

Likewise postfix asks questions and so does proftpd. I don't know if it's 
correct to preseed the debconf database with these answers, but it should be 
possible (see debconf(7)).

I prefer PostgreSQL to MySQL. Perhaps there should be two meta packages, 
vhcs-postgresql and vhcs-mysql that depend on vhcs + relevant database 
specific packages. That's not necessary if you're not willing to support that 
though.

Also is installing mysql-server necessary? It may be that the database is 
stored on a separate host so no database server is needed.

Are all the password debconf questions necessary? I haven't been through all 
of them, but I suspect some could be set to random strings, e.g. vhcs2 
database user. The root database account for MySQL has by default no 
password, so this question may not be necessary. The debconf question should 
probably mention this anyway.

Once I have answered all the questions I get an error on line 395 of 
vhcs.postinst - "can't remove system crontab". This is because root has no 
crontab (it's a clean install). This should possibly be are warning rather 
than a fatal error. Also a minor point: the crontab commands should probably 
be run with 2>&1 >/dev/null to stop "no crontab for root" messages being 
printed.

A similar problem on line 591 of the vhcs.postinst. I opted to make no postfix 
configuration in the postfix config (see comment above) so I have no postfix 
config to backup. These lines should probably be surrounded by 

if [ -f $main_cf ]
...
fi

or something similar.

Now on line 559 of the postinst the ln command fails, probably because I've 
run the postinst a few times to get it working. Adding the -f flag to ln 
should fix this.

After this I needed to tweak the php.ini for apache2 because of the bug in 
php4-mcrypt [1]. This should be fixed soon in sarge though.

OK, so I now have vhcs2 up and running. Good job! :)

I'll let you know if I come across any other problems. I know there's a lot of 
stuff here, but it pays to iron out as many wrinkles as possible before 
getting it into the archive, that way you don't end up having to implement 
transition strategies for various things when you fix it later.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=283305



Reply to: