Re: RFS: xmms-blursk

[Jochen Friedrich <jochen@scram.de>]

Hi

> * Package name : xmms-blursk
> Version : 1.3

Looks pretty good in general. However, a few nits to pick...

- please convert your files in the debian directory to UTF-8. The Debian
  policy requires this.
- please add either "DH_COMPAT=4" to your rules or execute "echo 4 >
  debian/compat", change "tmp" in your rules to "xmms-blursk" and change
  the version dependency on debhelper to ">> 4.0.0".
- On Alpha, i immediately get a Floating point exception. Please make
  sure, -mieee is added to the compile options to Alpha using something
  like:

configure.in:

AC_ARG_WITH(cflags,
[  --with-cflags=CFLAGS            use CFLAGS as compile time arguments.],
    [CFLAGS=$with_cflags; export CFLAGS])

Makefile.am:

COMMON_CFLAGS = @CFLAGS@ -I$(top_builddir) -I$(top_srcdir) -D_REENTRANT @GTK_CFLAGS@

debian/rules:

ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
        CFLAGS += -g
endif

ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
        CFLAGS += -O0
else
        CFLAGS += -O2
endif

ifneq (,$(findstring alpha,$(DEB_BUILD_GNU_TYPE)))
        CFLAGS += -mieee
endif

configure: configure-stamp
configure-stamp:
        ./configure --prefix=/usr --with-cflags="$(CFLAGS)"

--jochen