Re: Please have a look at this package
On Fri, Jun 06, 2003 at 04:39:27PM -0400, Matt Zimmerman wrote:
> On Fri, Jun 06, 2003 at 10:07:07PM +0200, Kevin Tappe wrote:
>> could you be so kind and have a look at the package located at
>> http://www.zerodivide.de/debian/rotn
>> It is a tiny tiny programme for rotating characters. ie you can use it
>> like rot13.
>> But beware this is the first .deb i have ever made - anywas lintian does
>> not report any warnings/errors.
E: rotn: binary-without-manpage rotn
Hello,
Basically it looks ok, there are two (easy to fix) real errors.
You built the package as native package, i.e. you generated a tarball
rotn_1.0-1.tar.gz that contains both upstream sources and the
modifications you made to them, instead of shipping the original
unchanged tarball and a diff.gz which _only_ contains your
modifications.
Place the original tarball in the parent-directory (e.g. /tmp/) of the unpacked
source-tree (e.g. /tmp/rotn-1.0/) and rename it to
packagename_upstreamversion.orig.tar.gz (rotn_1.0.orig.tar.gz) and use
"dpkg-buildpackage uc -us -sd -rfakeroot".
See developers' reference "5.4 Layout of the source package" for a
/little/ more detailed comments.
The other error is:
| # Add here commands to install the package into debian/rotn.
| /usr/bin/make install DESTDIR=/tmp/rotn-1.0/debian/rotn
| make[1]: Entering directory `/tmp/rotn-1.0'
| install rotn /usr/bin
| install: cannot create regular file `/usr/bin/rotn': Permission denied
You documented the necessary change
--------------------
--- Makefile.orig Sat Jun 7 11:15:54 2003
+++ Makefile Sat Jun 7 11:13:56 2003
@@ -10,5 +10,5 @@
clean:
rm -rf $(BINFILE) *~
install: rotn
- install $(BINFILE) $(INSTDIR)
+ install $(BINFILE) $(DESTDIR)$(INSTDIR)
--------------------
in debian/changelog but forgot to apply it (rotn_1.0-1.tar.gz).
The package does not include a manpage for the binary.
Nitpicking:
* Many of the commands you invoke in debian/rules (dh_installexamples,
dh_installmenu, dh_installcron, ...) are unnecessary. - You don't
ship any examples or a menufile or a crontab entry or ...
* Outdated Standards-Version. Debian/sid already ships policy 3.5.10
* I'd use debhelper compatibilty level 4.
> Is it necessary to dedicate a package to this one tiny tiny program?
> Also, there is already a program called 'rot13' or 'caesar' in bsdgames
> which does this.
Unnecessary bloat, use tr. ;-)
cu andreas
Reply to: