Re: looking for a sponsor for upsd...
Ok - a couple of comments:
I'm using unstable (Yes, I'm nuts :), and unstable uses GCC-3.2 - so the
compile had some warnings that some people MIGHT complain about (I've had
them generate bug reports on my packages because of them)...
Slightly more serious is a lintian warning (from the unstable lintian) that:
W: upsd: wrong-name-for-upstream-changelog usr/share/doc/upsd/Changes.txt.gz
information about this warning can be found:
http://lintian.debian.org/reports/Twrong-name-for-upstream-changelog.html
but the compiler warnings that I got were as follows:
gcc -Wall -O2 -DPWRSTAT="\"/etc/powerstatus\""\
-DCFGFILE="\"/etc/upsd.conf\"" -DUPSSTAT="\"/etc/upstatus\""
-DVERSION="\"v2.6\"" -c net.c -o net.o
net.c:98: warning: redefinition of `socklen_t'
/usr/include/unistd.h:247: warning: `socklen_t' previously declared here
net.c: In function `SigTerm':
net.c:144: warning: implicit declaration of function `exit'
gcc -Wall -O2 -DPWRSTAT="\"/etc/powerstatus\""\
-DCFGFILE="\"/etc/upsd.conf\"" -DUPSSTAT="\"/etc/upstatus\""
-DVERSION="\"v2.6\"" -c upsd.c -o upsd.o
gcc -Wall -O2 -DPWRSTAT="\"/etc/powerstatus\""\
-DCFGFILE="\"/etc/upsd.conf\"" -DUPSSTAT="\"/etc/upstatus\""
-DVERSION="\"v2.6\"" -c ups.c -o ups.o
ups.c: In function `UPS_Setup':
ups.c:127: warning: implicit declaration of function `exit'
gcc -Wall -O2 -DPWRSTAT="\"/etc/powerstatus\""\
-DCFGFILE="\"/etc/upsd.conf\"" -DUPSSTAT="\"/etc/upstatus\""
-DVERSION="\"v2.6\"" -c mapping.c -o mapping.o
gcc common.o net.o upsd.o ups.o mapping.o -o upsd
ups.o(.text+0x33): In function `UPS_Open':
: `sys_errlist' is deprecated; use `strerror' or `strerror_r' instead
the to fix the "exit" warning, just include stdlib.h (new "feature" in
GCC-3.2), as for the rest, to fix them or not is up to you.
Anyways, I usually say that I'm not uploading something for someone else until
it's lintian clean, so if you could just make the necessary minor change, and
let me know what you want to do about the compiler warnings. (if anything...
as I said above, it's not really necessary, but some people will complain and
file bugs against your package :). Once you get back to me, if everything is
fine, then I don't think that I'll have too much trouble uploading this for
you.
BTW - a couple of other quick things - do you have a GPG key, is it signed by
any Debian developer, and have you started the NM process?
Pat.
On Saturday 19 April 2003 12:52, Nick Estes wrote:
> > I might be interested in sponsoring you for this package, but I'd have to
> > take a look at what you've done. Do you have somewhere that I can get
> > your packaged upsd to take a look at it?
>
> Yep, you can find it in my home repository:
> deb http://nickstoys.com/debian/nickstoys testing main
>
> Or if you prefer, you can grab the files directly from:
> http://nickstoys.com/debian/nickstoys/pool/u/upsd/
>
> --Nick
--
Patrick Patterson
Open Source Ambassador
Net Integration Technologies
Reply to: