Re: Bug#89433: I want to adopt osh
On Fri, 18 Jan 2002 02:36:31 +0900,
Junichi Uekawa <dancer@netfort.gr.jp> wrote:
> Some things I noticed:
>
> o MAXPATHLEN is not available on some systems.
struct.h says:
| #ifndef MAXPATHLEN
| # define MAXPATHLEN 1024
| #endif
> p Is writing something like:
> Note that this license is not compatible with the GPL. This means that
> you can't redistribute the binary of osh if it is complied with libraries
> licensed under the GPL. The debian package is compiled with libc6 and
> libncurses5, which seem to have no problem to me (Oohara Yuuma), but I am
> not a lawyer.
> into a Debian pacakge copyright file a good idea?
I want to avoid a debian-legal flame like "osh violates the GPL".
> o DEB_BUILD_OPTIONS="debug,nostrip" && debuild
> will never work, because debuild does unset env vars.
> DEB_BUILD_OPTIONS="xxxx" dpkg-buildpackage
> DEB_BUILD_OPTIONS="xxxx" debian/rules
> should work though.
debian/rules says:
| # to compile with debugging information:
| # $ debuild -e DEB_BUILD_OPTIONS="debug,nostrip"
| # (this won't work:
| # DEB_BUILD_OPTIONS="debug,nostrip" && debuild)
Note the word "won't".
> o Why are you commenting out static char *rcsid ?
> o Adding extra {} in if statements does not seem to help anything
> o What is the point of:
> +/*
> fatal(mes)
> +*/
> +int fatal(mes)
> and other changes, with commented-out changes?
To avild gcc -Wall warnings.
debian/changelog says:
| * exp.c, handlers.c, main.c : hacked to avoid gcc warnings
| - added explicit braces to avoid ambiguous "else"
| - explicitly declared the return value of some functions as int
| - added some dummy return
| - commented out unused variables, including rcsid
| - moved definition of "Internal" to main
> o Why are you building the binary with -O3 -fomit-frame-pointer?
I like optimization, but I don't know it well. Can you tell me
a better option?
* -O : the old version (1.7-8.1) uses it
* -O2 : the Policy (version 3.5.6.0, section 11.1) suggests it
"Generally the following compilation parameters should be used:"
(by the way, it includes -Wall)
* -O3 : the Policy also suggests it for "Certain binaries (such as
computationally-intensive programs)"
> o are you sending the mods to the upstream ? / have you
> contacted the upstream ?
Not yet.
--
Oohara Yuuma <oohara@libra.interq.or.jp>
Graduate-school of Science, Kyoto University
PGP key (key ID F464A695) http://www.interq.or.jp/libra/oohara/pub-key.txt
Key fingerprint = 6142 8D07 9C5B 159B C170 1F4A 40D6 F42E F464 A695
I always put away what I take.
--- Ryuji Akai, "Star away"
Reply to: