Re: Looking for sponsor for: libapache-mod-sqlinclude, hd-dma
On Wed, 13 Nov 2002, Marcin Orlowski wrote:
> I've packaged mod_sqlinclude <http://sf.net/projects/mod-sqlinclude/>
> and small script hd-dma. Both can be found packaged at
> http://wfmh.org.pl/~carlos/debian/
I'm not seeing an .orig.tar.gz and a patch. Trust me on this - you want to
keep them separate, even if you are the only person working on it at this
stage. CVS has nice features for doing this - it's been discussed before,
but if you want my way of doing it, just ask.
> These are my first packages so I am open for all the
> improvement sugestions. And I'm looking for sponsor
> and uploader of course ;)
I'll sponsor at least mod_sqlinclude (I'm maintainer for mod_auth_mysql, as
well as upstream for it at present, so I know a bit about packaging apache
modules) but I'd prefer to do it the Proper Way (orig+diff).
My current list of suggestions for improvement are:
* orig+diff. I can't help it, it's my way, but I really don't like
non-native packages without orig+diff. Think of it as a sub-release if it
helps.
* Your LICENSE.txt file mentions mod_sqlinclude.c version 2.x, but your up
to 1.4. Residue from whatever you took your example from?
* No need to put gratuitous .txt extensions after things; this is Unix, we
are the Blessed People of the ASCII Format. <grin>
* Use autoconf for your Makefile. It's not really a Debian thing, but
hand-editing Makefiles gets real old, real fast. Check out the latest
(4.1.0) release of mod_auth_mysql for an example of how to do it (not the
best example, but functional(ish)).
* No need to leave an empty dirs file in debian/.
* I don't think your manual page actually documents the bar command. Also,
I don't see any info documentation. I commend your dedication in writing a
man page, though, but it needs a fair chunk of work.
* Your postinst needs to be taken out the back and put out of it's misery.
We have Debconf. It's cool. Please use it. Ditto for your prerm.
* Rip the commented-out debhelper calls out of rules. It's a niggly thing,
but there's no point leaving them in there.
And I think I've ripped your packagin skills to bits enough for one day.
<g>
--
Matthew Palmer, Debian Developer
mpalmer@debian.org http://www.debian.org
Reply to: