[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: need sponsor for vegastrike upload



On Tue, 2002-07-23 at 19:42, Colin Walters wrote:
> walters@space-ghost> diffstat ../vegastrike_0.2.9.2-4.diff.gz           /tmp/vegastrike/vegastrike-0.2.9
> [...]
>  mission/.deps/button.Po             |  117 ++++++
>  mission/.deps/easydom.Po            |  159 ++++++++
>  mission/.deps/file.Po               |  204 +++++++++++
>  mission/.deps/general.Po            |  131 +++++++
>  mission/.deps/glut_support.Po       |  115 ++++++
>  mission/.deps/graphics.Po           |  208 +++++++++++
>  mission/.deps/hashtable.Po          |  123 ++++++
>  mission/.deps/select.Po             |  208 +++++++++++
>  mission/.deps/selector.Po           |  208 +++++++++++
>  mission/.deps/text_area.Po          |  208 +++++++++++
>  mission/.deps/xml_support.Po        |  141 +++++++
> 
> Is it really necessary to create these files?  I bet they're just cruft
> that 'make clean' didn't remove.
hmm..  Missed these.  I'm building a -5 release now that gets rid of
these and it should be uploaded within the hour.
>  mission/Makefile                    |  358 +++++++++++++++++++
The original ./configure had a bunch of checks for python and such that
it didn't need so I rebuilt it.  There were other issues with the build
environment that stemmed from upstream releasing directly out of cvs. 
It was a compromise.  The build env will be better in the next upstream
release.

> Since the Makefile is generated from Makefile.in by configure, you
> shouldn't patch it in your diff.
> 
> [...]
>  objconv/Makefile                    |  226 ++++++++++++
>  saveinterface/Makefile              |   26 +
> [...]
>  vssetup/src/Makefile                |   29 +
> 
> Not sure about these.
the 2nd 2 are all my code that I added to make the thing compile.  Have
a look at some of the program code sometime and you'll see its not the
cleanest of src trees. :)

> Other than that, your package looks good.  I'd prefer it if you had your
> key signed by a Debian developer before I sponsor you.  Could you try to
> do that first?  At least the key:
It has been signed.  I'll waiting at that DAM stage.

> pub  1024D/B056CC96 2002-04-12 Michael E. Furr <mikefurr@hotmail.com>
Not me.  My key is in the wwwkeys.pgp.net group of servers.  I'll also
sign this email.  My key is
pub  1024D/124B26F3 2001-10-12 Mike Furr <mike.furr@umbc.edu>
     Key fingerprint = 5B9F 587F BC5C D823 50CE  4DB0 ED93 CA29 124B
26F3
uid                            Mike Furr (Authoritative Key)
<mike.furr@umbc.edu>
sub  1024g/C32B991D 2001-10-12

thanks!

-mike

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: