Hi Harish, harish chavre, on 2025-07-10: > Thank you for the detailed feedback. I have made the suggested > changes to the test script. The procps package has been added > to ensure ps works as expected. Ok, now the autopkgtest suite runs alright when started in an isolate environment. Good! > I have also reworked the error handling to avoid suppressing > any failures, so the test will now properly fail if either > gap4 or pregap4 crashes. Additionally, all related processes > are now being cleaned up at the end of the test. I would probably have made the checks fatal if the tclsh scripts were to go missing, for good measure; although in all likelyhood, the gap4 would probably be missing too and have crashed the autopkgtest already. The pre-cleanup step should not hurt; although strictly speaking it is expected to run in isolate environment anyway, one cannot anticipate all the use cases. > Please let me know if there is anything else that needs > attention. You may feel free to account my aforementioned remark about the fatality of the check on the tclsh script, but I believe that your autopkgtest work can be uploaded as-is and will send the package to experimental shortly. I brought various minor changes to refresh standards compliance and normalize patch headers timestamps, but nothing too interesting to spend time on. Thank you for your contribution! Have a nice day, :) -- .''`. Étienne Mollier <emollier@debian.org> : :' : pgp: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da `. `' sent from my alarm clock `-
Attachment:
signature.asc
Description: PGP signature