[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with



On Sat, Mar 30, 2024 at 02:26:07PM +0100, Sébastien Jodogne wrote:
> > For some reason, this is not taking needs-sudo restriction well. Can you try once with this
> > patch (no need to re-compile) and let me know if that helps?
> > 
> > diff --git a/debian/tests/control b/debian/tests/control
> > index 5e8c44d..4f9b12a 100644
> > --- a/debian/tests/control
> > +++ b/debian/tests/control
> > @@ -1,3 +1,3 @@
> >   Tests: run-unit-test
> >   Depends: @, python3, orthanc, curl, libcurl4, orthanc-python, procps
> > -Restrictions: needs-sudo, allow-stderr, isolation-container
> > +Restrictions: allow-stderr
> 
> Wonderful! I confirm that with this patch, I am able to run autopkgtest as
> follows:
> 
> $ sudo autopkgtest -B ../build-area/orthanc-python_4.1+ds-3_amd64.deb --
> null
> 
> I have just uploaded it:
> https://salsa.debian.org/med-team/orthanc-python/-/commit/3cdc765442ab3fce9148c33ba865467983b11e0b

Actually, the patch was more of a local workaround based on your system configuration and should
stay the way it was for debci based workers/lxc backend. With that change the autopkgtest job fails[1]
and that's a bad sign :-)

> Now, the next problem is: The test always succeeds on my standard amd64
> architecture. Despite many attempts, I am totally unable to reproduce
> #1062404.
> 
> @Paul: How could I reproduce the issue?
> 
> @Nilesh: Shouldn't this test simply be disabled?

The test was added to ensure the binary actually works with rest of the Debian ecosytem -- if you
feel that's not needed, sure feel free to drop it -- your judgement is more qualified than mine since
you're the upstream maintainer, so I defer that decision onto you.

[1]: https://salsa.debian.org/med-team/orthanc-python/-/jobs/5519508

Best,
Nilesh

Attachment: signature.asc
Description: PGP signature


Reply to: