Re: Cmake help needed for ncbi-vdb
On Wed, Feb 23, 2022 at 5:26 PM Andreas Tille <tille@debian.org> wrote:
>
> Hi Mathieu,
>
> Am Mon, Feb 21, 2022 at 09:29:46AM +0100 schrieb Mathieu Malaterre:
> > > The point is that the linker flags to libmbedtls-dev, zlib and others
> > > need to be set. Excluding references to code copies was easy[2] ... but
> > > now we need the according -l options and my cmake knowledge is to weak.
> >
> > I've pushed a ugly hack... hopefully this can be discussed with
> > upstream for a better integration.
>
> Thanks a lot for this patch. It helped compiling the code.
>
> Unfortunately the build is not yet correct since the -soname options
> included into the build are wrong. For instance the compile option that
> is generated is in the current configuration for instance:
>
> ... -shared -Wl,-soname,libkdf5.so ...
>
> while the correct soname would be
>
> ... -shared -Wl,-soname,libkdf5.so.3 ...
>
> (according to the fact that libkdf5.so.3.0.0 is created.) I tried to
> fix this with the patch
>
>
> --- a/libs/hdf5/CMakeLists.txt
> +++ b/libs/hdf5/CMakeLists.txt
> @@ -54,3 +54,5 @@ if( HDF5_FOUND )
> ExportShared( kdf5 true "${HDF5_LIBRARIES};ncbi-vdb" )
>
> endif()
> +
> +SET_TARGET_PROPERTIES(kdf5 PROPERTIES OUTPUT_NAME kdf5 SOVERSION 3)
I do not have access to my linux workstation, but can you try something like:
set_target_properties(kdf5 PROPERTIES VERSION 3.0.0 SOVERSION 3)
>
> but for some reason this does not have any effect. Do you have any
> idea how to set SONAME correctly?
>
> Kind regards
>
> Andreas.
>
> --
> http://fam-tille.de
Reply to: