nthash is fine - please review two other packages. :-) (Was: [Request for review] nthash)
On Fri, Mar 26, 2021 at 09:02:27PM +0530, Nilesh Patra wrote:
> I packages nthash which lives in the salsa repository here
> Salsa CI shows all good, and it also cross-builds successfully in my
> Please consider doing a review and upload, or give me a green signal and
> I'll do so.
I've just added citation information. Please check the probably
unneeded empty file debian/tests/test1. Feel free to upload yourself.
It looks good from my point.
I wonder whether you (or whoever likes to!) like to have a look at
python-lineages. I did not found any license information
specifically I'm not sure about the included font.
Another review is needed for pangoLEARN. Both are preconditions
for pangolin which is used in the covpipe pipeline. The issue for
pangoLEARN package is:
Traceback (most recent call last):
File "/usr/bin/pangoLEARN", line 33, in <module>
sys.exit(load_entry_point('pangoLEARN===2021-03-16', 'console_scripts', 'pangoLEARN')())
File "/usr/bin/pangoLEARN", line 25, in importlib_load_entry_point
File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
module = import_module(match.group('module'))
File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 984, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'pangoLEARN.command'
> : https://salsa.debian.org/med-team/nthash