[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Urgent: Spades Update before freeze



Hi,

there was an answer to the opened issue here:

   https://github.com/ablab/spades/issues/671#issuecomment-786692020

I'm not really sure how this relates to the problem Juhani has
described and unfortunately I'm currently lacking the time to
work on this (due to real life things that weekend).

Kind regards

     Andreas.

On Fri, Feb 26, 2021 at 03:12:52PM +0100, Andreas Tille wrote:
> Hi Juhani,
> 
> thanks a lot for your attempt to help.  Since I personally do not
> have the slightest idea of llvm I opened an issue upstream[3].
> 
> Kind regards
> 
>        Andreas.
> 
> [3] https://github.com/ablab/spades/issues/671
> 
> On Fri, Feb 26, 2021 at 02:18:56PM +0200, Juhani Numminen wrote:
> > Hi all,
> > 
> > For context:
> > The spades problems are because of non-dfsg ConvertUTF.cpp (and .h)
> > coming from a local fork of LLVM. Lintian reports an error
> > for that[1], so we would want to get the ConvertUTF.cpp removed
> > from the package.
> > 
> > Andreas Tille kirjoitti 18.1.2021 klo 19.42:
> > > Hi,
> > > 
> > > thanks to a hint of Juhani here I striped llvm from the upstream source
> > > and tried again (please git pull if you just have a clone of the spades
> > > Git repository).  Unfortunately also here the build does not succeed:
> > > 
> > > ...
> > > /usr/include/llvm/Support/YAMLTraits.h:1124:36: error: invalid application of 'sizeof' to incomplete type 'llvm::yaml::MissingTrait<std::map<int, long unsigned int> >'
> > >   1124 |   char missing_yaml_trait_for_type[sizeof(MissingTrait<T>)];
> > 
> > > May be I made some mistake with the llvm replacement?  Any hint would
> > > be welcome.
> > 
> > I worked on spades for a bit, and the above error has most likely
> > to do with spades-only local changes to LLVM[2]. Don't know how
> > extensive their modifications are. It would be great if spades
> > developers could structure their llvm changes in such a way that we
> > could use the debian-provided llvm.
> > 
> > I also tried a method of just stripping ConvertUTF.cpp out of the
> > package, then linking against debian's LLVMSupport.a static lib.
> > (Pushed to master branch just now.)
> > This produces the autopkgtest error of
> > 
> > Exception caught /home/juhani/Projektit/deb/spades/spades/spades_test/K33/configs/config.info(3): cannot open include file simplification.info
> > 
> > That might be a dead end then.
> > 
> > 
> > Regards,
> > Juhani
> > 
> > [1] https://lintian.debian.org/tags/license-problem-convert-utf-code.html
> > [2] https://github.com/ablab/spades/blob/spades_3.15.1/assembler/ext/src/llvm/YAMLTraits.cpp#L939
> > 
> > 
> 
> -- 
> http://fam-tille.de
> 
> 

-- 
http://fam-tille.de


Reply to: