Re: RFS: nim-hts (hts-nim on sheet)
Hi Nilesh,
On 01.11.20 08:34, Nilesh Patra wrote:
> Hi,
>
> On Sun, 1 Nov 2020 at 09:41, Steffen Möller <steffen_moeller@gmx.de
> <mailto:steffen_moeller@gmx.de>> wrote:
>
> Hello,
>
> https://salsa.debian.org/med-team/nim-hts
> <https://salsa.debian.org/med-team/nim-hts> seems ready to upload
> to me.
> Please kindly give it some extra eyeballs and typically it is Andreas
> who kindly uploads but feel free to help him out.
>
>
> I took the liberty to do a few changes here:
>
> * Added d/watch
;) I had deleted mine by accident. Many thanks!
> * Did repacking to remove binary files which would be otherwise
> rejected by FTP masters
I saw
tests/HG02002.bam | Bin 435867->
0bytes
tests/HG02002.bam.bai | Bin 16880->
0bytes
tests/other-for-test.bcf.csi | Bin 103-> 0bytes
tests/sa.bam | Bin 35116->
0bytes
tests/sa.bam.bai | Bin 11896->
0bytes
tests/test.bcf.csi | Bin 103-> 0bytes
tests/test.vcf.gz.tbi | Bin 103-> 0bytes
tests/test_files/simple.tsv.gz.csi | Bin 112-> 0bytes
and you have consequently disabled the corresponding tests? This seems
unfortunate to me.
Since not much disk space is invested, I doubt that the FTPmasters would
mind. The files are binary only because they are compressed, not because
they are constructed with some tool that Debian does not have. And they
are not essential for the program but only for testing its
functionality. I truly confident that this would be ok with the FTPmasters.
> * Re-generated the binaries for testing in d/rules during dh_auto_test
> * Added Autopkgtest
> * A few minor changes, additions and fixes
>
> Please consider to review my changes and let me know if they are fine
> - $git pull :-)
First of all - many thanks!
I would not like it if we now test less than we would have done with my
initial submission and would like Andreas to have a look at it prior to
an upload.
Best,
Steffen
Reply to: