Re: Request for a sponsored upload of fast5-research
Hi Nilesh,
On Wed, Aug 05, 2020 at 02:25:27AM +0530, Nilesh Patra wrote:
> Looks good to me. I've done these:
> 1. Added Autopkgtests
> 2. Change archs to all instead of any
Very nice.
> 3. Run wrap-and-sort for aesthetic styling - just so that it looks sorted.
In the end I don't mind a lot - there are good reasons for wrap-and-sort.
However, this will finally confuse Shayan again since he once had moved
python3-setuptools upwards which was reverted now by wrap-and-sort.
I also feel that moving variables ${misc:Depends} and ${python3:Depends}
to the end of the list is wrong and this change feels
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,3 +1,3 @@
Tests: run-unit-test
-Depends: @, python3-all, python3-nose
+Depends: python3-all, python3-nose, @
Restrictions: allow-stderr
absolutely wrong to my taste. In the first moment I was thinking @ would
be missing.
I'll sponsor as is but I guess the following source-only upload has
some candidates for changing. ;-)
> Enough nitpicking at my end I guess, this is good to go :-)
Nitpicking is always welcome and I'll upload as is.
Thanks to you both for your work on this package
Andreas.
--
http://fam-tille.de
Reply to: