Quast test issues solved, needs stripping of minimized JS (Was: QUAST - builds with cowbuilder, does not test, though)
Hi Steffen,
On Wed, Jun 24, 2020 at 07:15:50PM +0200, Steffen Möller wrote:
> This needs a bit of a JavaScript clean-up
Yep:
E: quast source: source-is-missing quast_libs/html_saver/static/bootstrap/bootstrap-tooltip-5px-lower.min.js
E: quast source: source-is-missing quast_libs/html_saver/static/bootstrap/bootstrap.min.js
E: quast source: source-is-missing quast_libs/html_saver/static/flot/jquery.flot.js line length is 2964 characters (>512)
E: quast source: source-is-missing quast_libs/html_saver/static/flot/jquery.flot.navigate.js line length is 1984 characters (>512)
E: quast source: source-is-missing quast_libs/html_saver/static/flot/jquery.flot.pie.js line length is 259 characters (>256)
E: quast source: source-is-missing quast_libs/html_saver/static/flot/jquery.flot.resize.js line length is 863 characters (>512)
E: quast source: source-is-missing quast_libs/html_saver/static/ie_html5.js line length is 2252 characters (>512)
E: quast source: source-is-missing quast_libs/html_saver/static/jquery-1.7.2.min.js
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/flot/excanvas.js please use libjs-excanvas
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/flot/excanvas.min.js please use libjs-excanvas
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/flot/jquery.js please use libjs-jquery
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/flot/jquery.min.js please use libjs-jquery
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/jquery-1.7.2.min.js please use libjs-jquery
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/jquery-1.8.2.js please use libjs-jquery
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/jquery-1.8.2.min.js please use libjs-jquery
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/jquery-ui.js please use libjs-jquery-ui
W: quast: embedded-javascript-library usr/lib/python3/dist-packages/quast_libs/html_saver/static/jquery.css please use libjs-jquery
> and the tests are not testing right.
I think I have solved this. :-)
> I had continued where Andreas has suspended his removal of foreign code
> and binaries from the upstream code base. This was more than just
> cosmetics because of rather crude license violations as with
> https://github.com/ablab/quast/blob/master/quast_libs/genemark/linux_64/LICENSE
> , which renders this even non-redistributable.
Very cool if quast can be used sensibly even without these executables.
Remark: Genemark itself needs tandemrepeatfinder where upstream promised
to get it freed soon. Once this is done we can nag genemark authors. :-P
> My understanding is that augustus can to some degree compensate for the
> non-availability of genemark, but this has to be seen.
I have to leave this question to the competence of you and the readers here.
> Whoever feels like it, please continue with the packaging.
... which for the moment means getting rid of the minimized JS.
Any volunteer would be really welcome.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: