Hello Nilesh, > If I may suggest ... > You can run the test on your machine manually once and you'll get output > file(s). This is something you can diff against. > > Add those files to say "debian/tests/expected/" and install these files > as examples and take diff with what you get when you run-unit-test. That's a great suggestion. Though, the only reason I didn't do this was what if the output generated on my machine was incorrect (which has happened a good few times). It's something I've personally always been more comfortable with letting upstream do that (especially as they can cross-check the expected results to see if it is truly 'expected'), but I think it's something I can let upstream know with adding these expected output within the upstream tarball. > +1: I use stable as well. > I have another debian-sid "schroot" made. > For cme I always do this: > > $ schroot -c debian-sid > $ cme fix dpkg > $ exit Ahh great, thank you! I wasn't aware of this. I've initially always been doing normal packaging on my buster machine, hoping I'd remember to change the standards version back (which isn't always the case) and then just running `gbp buildpackage --git-builder=sbuild -A -v -d unstable` to build, test and check the package. Kind regards, Shayan Doust On 16/06/2020 22:47, Nilesh Patra wrote: > > > On Wed, 17 Jun 2020, 03:08 Shayan Doust, <hello@shayandoust.me > <mailto:hello@shayandoust.me>> wrote: > > Hello Andreas, > > > I've done some minor changes and was building the package. > Unfortunately > > my computer crashed when ... or rather after(!) ... running the test. > I've > > seen > > > > [1] PASS > > > > on the screen and than my screen froze. No ssh login possible any > more. > > Waiting for more than 10min. I switched power-off and reboot worked > > fine (so no harm done) but I'm tired now and want to go to bed. I do > > not think that its actually related to the test - since the > > > > echo "[1] PASS" > > That's very odd. I know that NanoFilt will either pass or fail when > executing the command, but I like checking and making sure the filesize > is greater than 0 bytes as a double defense of making sure the program > *actually* does work properly as I have nothing to diff against. > > > If I may suggest ... > You can run the test on your machine manually once and you'll get output > file(s). This is something you can diff against. > > Add those files to say "debian/tests/expected/" and install these files > as examples and take diff with what you get when you run-unit-test. > > > Also this standard version changing is a bad practice for me, as I use > Buster for my main workstation, and it seems like cme loves changing the > standards version to a lower one (and I keep forgetting to set it back > to 4.5.0. > > > +1: I use stable as well. > I have another debian-sid "schroot" made. > For cme I always do this: > > $ schroot -c debian-sid > $ cme fix dpkg > $ exit > > Works out of the box. > > > Thanks for letting me know about not needing to add GPL text. I didn't > think twice of it because I used the full license text within another > package (mmseqs2?), at least that saves time now. :) > > > I'm to tired for today now. > > Good night and kind regards, > Shayan Doust > > On 16/06/2020 22:28, Andreas Tille wrote: > > Hi Shayan, > > > > On Tue, Jun 16, 2020 at 08:48:51PM +0100, Shayan Doust wrote: > >> > >> I believe nanofilt[1] is ready. Please check and, if green light > given, > >> upload :) > > > > I've done some minor changes and was building the package. > Unfortunately > > my computer crashed when ... or rather after(!) ... running the > test. I've > > seen > > > > [1] PASS > > > > on the screen and than my screen froze. No ssh login possible any > more. > > Waiting for more than 10min. I switched power-off and reboot worked > > fine (so no harm done) but I'm tired now and want to go to bed. I do > > not think that its actually related to the test - since the > > > > echo "[1] PASS" > > > > is actually the end of the script and syslog also looks harmless. But > > I'm to tired for today now. > > > > Thanks for your preparation > > > > Andreas. > > > >> Kind regards, > >> Shayan Doust > >> > >> [1]: https://salsa.debian.org/med-team/nanofilt > > > > pub RSA 4096/19D02395 2019-09-04 Shayan Doust (Personal EMAIL) > <hello@shayandoust.me <mailto:hello@shayandoust.me>> > >> > > > > > > > > >
Attachment:
0x6D7D441919D02395.asc
Description: application/pgp-keys
Attachment:
signature.asc
Description: OpenPGP digital signature