Re: RFS: Statistics::PCA

[Utkarsh Gupta <utkarsh@debian.org>]

Hi Étienne,

On Fri, Jun 12, 2020 at 10:07 PM Étienne Mollier
<etienne.mollier@mailoo.org> wrote:
> With the recent inclusion of packages libmath-matrixreal-perl
> and libmath-cephes-perl in Debian, putting the package
> libstatistics-pca-perl in good shape has become quite easy.
> Statistics::PCA is available on Salsa and ready for review:
>
>         https://salsa.debian.org/perl-team/modules/packages/libstatistics-pca-perl
>
> I tried to make sure autopkgtest and lintian with pkg-perl
> profile had no reasons to complain.

Nice :)
Just a small nitpick, lintian shows:
        upstream-metadata-file-is-missing
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Would you mind adding a d/upstream/metadata file?
(an example could be libminion-backend-sqlite-perl)

Also, you shouldn't push the debian tag yourself. It is to be pushed
when the package has been uploaded.
Generally, the one who sponsors your upload pushes that :)

Once these are fixed, let me know, I'll be happy to take another look
and sponsor this :)

> Have a nice day,  :)

Likewise! \o/


Best,
Utkarsh