[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Droping pyqi which seemed to be needed for qiime1 only (Was: Bug#954500: pyqi: FTBFS: dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2)



Hi

On Mon, 30 Mar 2020, 17:12 Andreas Tille, <tille@debian.org> wrote:
Hi,

I fixed the actual issue in Git but got a new error:


...
   dh_auto_test -O--buildsystem=pybuild
I: pybuild base:217: cd /build/pyqi-0.3.2+dfsg/.pybuild/cpython3_3.8/build; python3.8 -m unittest discover -v
/build/pyqi-0.3.2+dfsg/.pybuild/cpython3_3.8/build/pyqi/core/interfaces/html/__init__.py:359: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if full_name in postvars and i.Type is not 'upload_file':
pyqi.core.interfaces.html (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: pyqi.core.interfaces.html (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: pyqi.core.interfaces.html
Traceback (most recent call last):
  File "/usr/lib/python3.8/unittest/loader.py", line 470, in _find_test_path
    package = self._get_module_from_name(name)
  File "/usr/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/build/pyqi-0.3.2+dfsg/.pybuild/cpython3_3.8/build/pyqi/core/interfaces/html/__init__.py", line 25, in <module>
    from cgi import parse_header, parse_multipart, parse_qs, FieldStorage
ImportError: cannot import name 'parse_qs' from 'cgi' (/usr/lib/python3.8/cgi.py)

Just checked, none of the cgi imports (parse_header, parse_qs et al) are being used anywhere in the file. 
Imo, you can just delete this import line.
On doing that, build passed for me.



----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)
E: pybuild pybuild:352: test: plugin distutils failed with: exit code=1: cd /build/pyqi-0.3.2+dfsg/.pybuild/cpython3_3.8/build; python3.8 -m unittest discover -v
dh_auto_test: error: pybuild --test -i python{version} -p 3.8 returned exit code 13
...


Since pyqi has no rdepends any more and IMHO was only packaged
for qiime version 1.x I'd suggest to remove this package.

Am I missing something?

Regards, Nilesh.

Reply to: