[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#909716: Request for sponsoring changes in idba



Hi Andreas,

On Sun, Mar 8, 2020 at 12:54 PM Andreas Tille <tille@debian.org> wrote:
Hi Pranav,
I hope you are happy with your result.

Thank you, they went quite well. 

May be adding some binary package idba-extra (or some better name you
might find) to ship these additional tools that might be not needed in
every day use but might be helpful anyway for some use case - for
instance testing the package.

> Also, would it be possible to have some programs available only during
> testing, but not in the finall installation? Then we could run sim_reads
> that way and avoid all the static data.

Yes, for instance in an extra binary package.  While we could even run
autopkgtest inside a compiled source tree I personally prefer to ship
every tool inside some binary Debian package to enable users reproducing
the test results on their installation.

Yes, this makes sense. I have added another package called idba-extra.
 
Than you do

    git mv debian/install  debian/idba.install
    git mv debian/manpages debian/idba.manpages

(which is strictly speaking redundant since by default debian/install
and debian/manpages are affecting the first binary package - but I
consider this better) and create a

    $EDITOR debian/idba-extra.install

package listing all tools you want to install into this package.

One small problem I ran into: There was no debian/install file originally, so I couldn't figure out how it is that these files are being copied. Is it something to do with make install?
I've added debian/idba.install and debian/idba-extra.install, and everything works as expected.
Although, the following warnings are generated during testing.

dh_missing: warning: usr/bin/idba_tran exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/bin/validate_blat_parallel exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/bin/validate_blat exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/bin/idba_ud exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/bin/scan.py exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/bin/idba_hybrid exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/bin/run-unittest.py exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/bin/idba exists in debian/tmp but is not installed to anywhere

Please check debian/*.install and see if these are right.

I have also changed the test files now. Only a few necessary files are included, and the rest are generated during testing.
Let me know if I missed anything, otherwise please review and sponsor these changes. 
 
Hope this short intro is helpful.

It was very helpful, indeed. I have a few more queries, though. 
I was trying to find more information about the structure of packages and I found these two guides: 
Are these okay, or would you recommend some other resource?

Also, now that we have included some new programs in the idba-extra package, how can I generate man pages for them? I noticed that it is the debian/*.1 files that correspond to manpages, and are generated using help2man.
But as far as I understand, help2man needs the executable, which is produced only inside the testing chroot. So, do I run help2man inside the chroot, or is there another way?
And does anything else need to be done, when a new package is added?

Please reply whenever it is convenient for you.

Regards, 
Pranav

Reply to: