[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Outreachy success (Was: Bug#906980: kmer: autopkgtest fails with segfault in testing/unstable while it passes in stable)



Hi Liubov,

On Wed, Aug 29, 2018 at 04:22:10PM +0200, Liubov Chuprikova wrote:
> On Mon, 27 Aug 2018 at 17:02 Andreas Tille <andreas@fam-tille.de> wrote:
> > Ahhhhh, finally a pretty simple solution for a quite hidden problem.
> 
> I admit I have expected something more serious :-)

I think those hidden problems are quite serious. 
 
> > BTW, I wonder whether there are tools that would warn about issues
> > described in[1] - I think there are good means to detect this
> > automatically.
> 
> I checked clang-tidy and it can warn about such issues. One more tool I
> would like to know now together with continuing of learning C.

Good.  May be it makes sense to check kmer with this.  It could be
that there are other hidden problems which simply did not came into
effect.
 
> > Would you please forward this solution to upstream?  May be once you
> > contact upstream asking for a versioned release for download would be a
> > good idea.
> 
> I wrote to upstream about the bug. Hope, they are interested in providing
> new releases.

Good. 

> > Please note that I moved the data file into a separate package
> > kmer-examples to avoid duplication of the data files and enable users
> > installing the code without the data.  Thus the package needs to pass
> > the new queue (hope this will happen soon).
> 
> Yes, thank you for this! I was not sure about putting data in a separate
> package as the data were small and there were no lintian warnings about
> this.

Lintian warns if the amount of architecture independent data in an arch
any package is above a certain percentage of the package.  May be there
is a way to craft a nifty rule in lintian to detect if the same data are
spread over different binary packages.  I think that's just useless if
the data set is not "really" small.
 
> > Thanks a lot for you fine work.  I think this issue is something you
> > can be really proud about since your work uncovered an issue and you
> > finally was able to fix it.
> 
> I was happy to finally delete kmer from my list as it was hanging for so
> long :-P

:-) 
 
> > I really hope you will be able to
> > continue this work even if GSoC is close to finished.  May be, if you
> > have time you could continue a bit.
> 
> I'd be very happy about this.

That's very good.
 
> Many, many thanks to you for mentoring me! I definitely have time till
> September 10 before my master program starts. I would like to look into
> unicycler and maybe something else.

It would be very helpful if we could make some progress with this.
 
Kind regards

       Andreas.

-- 
http://fam-tille.de


Reply to: