Re: uploading libzstd...
Hi Mattia,
> Alexandre Mestiashvili: you prepared the last updates (referring to
> importing the new upstream releases), but it's clear you never did a
> copyright review. Please always check what you imported for updates in
> the copyright or the licensing details.
Let me please elaborate my point of view. libzstd is team-maintained,
and because I didn't see any changes in the copyright/licensing for the
new upstream versions I obviously didn't think on checking the
copyright. Especially taking into account that the package has already
been successfully uploaded multiple times.
> I removed the hurd-i386 patch, according to the upstream bug report the
> actual issue has been fixed now (didn't test myself though).
Upstream solved only part of the issue. One of the tests takes too long
or too much memory on hurd as far as I remember and the patch was
addressing this problem. The Forwarded header doesn't apply anymore for
the current patch but it was correct for the initial version.
> Then, the actual issue, the symbol files.
> Alexandre Mestiashvili: it's not acceptable to just happily remove
> symbols. I don't understand what happened as the git log of that file
> is noisy, but looking at a simple debdiff the following symbols
> disapperead:
>
> - ZSTD_initCCtxParams@Base 1.3.2
> - ZSTD_initCCtxParams_advanced@Base 1.3.2
> - ZSTD_resetCCtxParams@Base 1.3.2
>
> Where did they went? I can't sensibly upload something that is removing
> symbols (i.e. breaking the ABI, but it seems to me that it also break
> the API?) without changing SONAME or giving a proper explanation.
My bad. It seems that I don't understand enough how to properly handle
symbols. I just was following the manual[0].
I'd really appreciate if somebody would explain what should have been
done in order to generate symbols files in this case.
First symbols file was generated after building libzstd 1.3.2+dfsg1-1
installing it and running dpkg-deb and dpkg-gensymbols as described here[0].
The last file was generated the same way, I just preserved the versions
of already existing symbols.
No idea why the 3 symbols above have disappeared. Again I'll be really
interested to hear what I did wrong.
>
> I'll be doing some git wrestling and cutting a 1.3.3+dfsg-2 with the
> commits that can go in (and then merging in master).
> The last point is a blocker for an update to 1.3.4.
>
Also I am a bit surprised of the mentoring tone of the message. Thank
you for your work but why can't it be resolved by submitting bugs for
every single issue as for example Helmut did? Is that the importance of
libzstd?
Thanks!
Alex
[0] https://wiki.debian.org/UsingSymbolsFiles
Reply to: