Re: Bug#865552: libbpp-phyl FTBFS with test failures

[Andreas Tille <andreas@an3as.eu>]

Hi Julien,

On Wed, Jul 12, 2017 at 03:35:42PM +0200, Julien Yann Dutheil wrote:
> Ok, it is now working. I have fixed the header pb on libbpp-seq and added
> and committed a patch following instructions in your last email.

Thanks for the patch.  I've turned it into a quilt patch and uploaded.

> I have to
> admit I find that totally confusing... why adding patches when git has all
> the history, isn't committing the changes enough?

Debian packaging is older than Git.  The fact that we are using Git to
maintain the packaging does not mean that the packaging process can rely
on Git features.  If some user intends to download the package source
via

    apt-get source libbpp-seq

your changes in Git are not visible.  So this kind of changes are really
made by quilt patches.  As far as I know and others here on this list
might comment about (that's why I again forward your mail to the list
and I keep on recommending using it right in the first place) there are
some tools that are able to turn git changes into a quilt patch but I
have not used these.

> Also I am not sure what you intend by "explicit notification"... not
> sending an email to the full list, right?

Well, your changes made it to the commit mailing list[1] and I would
have noticed this.  However, it would be nice if you could send an
additional e-mail to the Debian Med list to explain that you would like
this change to be uploaded or whether it is just an intermediate change
which needs other changes to finalise an uploadable package.  Sorry for
beeing a bit short about this.

Thanks for your changes - please pull my changes to learn how to do
things properly in line with Debian packaging standards.

Kind regards

      Andreas.


[1] https://lists.alioth.debian.org/pipermail/debian-med-commit/2017-July/066171.html
 
> On Fri, Jul 7, 2017 at 4:49 PM, Andreas Tille <andreas@fam-tille.de> wrote:
> 
> > your login is
> >
> >    jdutheil-guest
> >
> > its described in the docs that non-DDs need to add -guest to the user name.
> >
> > Hope this helps
> >
> >      Andreas (feel free to post such mails to the list as well!)
> >
> > On Fri, Jul 07, 2017 at 02:51:37PM +0200, Julien Yann Dutheil wrote:
> > > Dear Andreas,
> > >
> > > I am aware that this email will not reach you until you are back from
> > > vacation. It is just to mention that I do not seem to have access to the
> > > git repositories. Read only access works (anonscm.debian.org), but not
> > when
> > > I use my login (git://jdutheil@debian.org), as I get a permission
> > error. I
> > > have searched the debian wiki pages to see if there was some way to apply
> > > for that, but was not successful, and I am a bit unsure about whom to
> > > contact. Do you think we could start this month monitoring thing in
> > > mid-august? I guest that would be the most efficient way so that I stop
> > > bothering you for every small thing...
> > >
> > > Best regards,
> > >
> > > Julien.
> > >
> > >
> > > On Tue, Jun 27, 2017 at 12:02 PM, Andreas Tille <tille@debian.org>
> > wrote:
> > >
> > > > Hi Julien,
> > > >
> > > > On Tue, Jun 27, 2017 at 11:45:52AM +0200, Julien Yann Dutheil wrote:
> > > > > >
> > > > > > IN any case as response to the bug report.  This would enable
> > others
> > > > > > to fix it even if I'm on vacation (which will happen for instance
> > from
> > > > > > tomorrow on for two weeks - so please stick to public channels like
> > > > > > the mailing lists).
> > > > > >
> > > > > I was unsure as you mentionned that the bug should be now closed, so
> > was
> > > > > not sure whether this should be in some kind of new thread or so.
> > > >
> > > > I did not yet closed the bug since I've got no confirmation from the
> > > > reporter that he is OK.  You can always check a bug status in this case
> > > > by
> > > >
> > > >    https://bugs.debian.org/865552
> > > >
> > > > Even if the bug would have been closed mails will be delivered to those
> > > > who have subscribed the Maintainer mailing list.
> > > >
> > > > > > Extra points for sure if you commit this to the packaging Git as
> > quilt
> > > > > > patch as I did right now.  If I remember correctly you are a
> > member of
> > > > > > the Debian Med team and have commit permissions.
> > > > >
> > > > > Just applied to that indeed, but I'm not yet familiar on how things
> > work.
> > > > > Really need to find some time to do that 1 month training :s
> > > >
> > > > In this case:
> > > >
> > > >     gbp clone ssh://git.debian.org/git/debian-med/libbpp-phyl.git
> > > >     # alternatively  git clone
> > > >     cd libbpp-phyl
> > > >     cp <your_patches> debian/patches/
> > > >     echo <name_of_patch_files>  >> debian/patches/series
> > > >     quilt push
> > > >     quilt refresh
> > > >     ... # until you dealt with all patches
> > > >     quilt pop -a
> > > >     git add debian/patches/*
> > > >     dch -i
> > > >      # add a changelog entry, close the bug
> > > >     git commit -a
> > > >     git push
> > > >
> > > > I'm reading the commit list and see your changes - explicit
> > notification
> > > > would be nice.
> > > >
> > > > > > Thanks for your help in any case.  Please also try to fix the
> > header
> > > > > > issue in bpp-seq upstream.
> > > > >
> > > > > Will look at that. Thank you very much and enjoy your vacations.
> > > >
> > > > You are welcome and thanks for the wishes
> > > >
> > > >       Andreas.
> > > >
> > > >
> > > > --
> > > > http://fam-tille.de
> > > >
> > >
> > >
> > >
> > > --
> > > Julien Y. Dutheil, Ph-D
> > > 0 (+49) 6421 178 986
> > >
> > > § Max Planck Institute for Evolutionary Biology
> > > Molecular Systems Evolution
> > > Department of Evolutionary Genetics
> > > Plön -- GERMANY
> > >
> > > § Institute of Evolutionary Sciences - Montpellier
> > > University of Montpellier 2 -- FRANCE
> >
> > --
> > http://fam-tille.de
> >
> 
> 
> 
> -- 
> Julien Y. Dutheil, Ph-D
> 0 (+49) 6421 178 986
> 
> § Max Planck Institute for Evolutionary Biology
> Molecular Systems Evolution
> Department of Evolutionary Genetics
> Plön -- GERMANY
> 
> § Institute of Evolutionary Sciences - Montpellier
> University of Montpellier 2 -- FRANCE

-- 
http://fam-tille.de