Hi Michael, thanks for polishing the packages! > - I would add: > Copyright 1999, N. Jesper Larsson, all rights reserved. > from ls.h to d/copyright > Done > - IMHO d/rules should have a ‘clean' override that removes the man pages built there > Already taken care of via dh_clean and d/clean: "debian/*.1" > > - The watchfile doesn’t have any active entries? The following should work: > opts=pasv \ > ftp://ftp.ccb.jhu.edu/pub/infphilo/hisat2/downloads/hisat2-([0-9.]+)-source.zip > > Done, thanks! > > - The package does not build reproducibly for me — likely because I have disorderfs enabled in my prebuilder setup, which is not the default. It might help wrapping the $(wildcard …) lines in the Makefile with $(sort …) etc. See https://reproducible-builds.org/docs/stable-inputs/. > > Done, thanks for the tip. Uploaded! > and python3-typed-ast: > > - Lintian still warns about the (easy to fix): > W: python3-typed-ast source: syntax-error-in-dep5-copyright line 25: Continuation line outside a paragraph (maybe line 24 should be " .”). > - There are two license entries for ‘Files: *’ in d/copyright. From what I can see, only typed_ast/ast27.py and typed_ast/ast35.py are Python licensed, so it might be enough to set those two to License: Python, keeping the rest as Apache 2.0? > > I'm committed a clarification Uploaded, with some minor changes, see git. > - Since the package seems to be quite generic, it may be better maintained with/in the DPMT [1]? > What do you think? > > I'm not familiar with that team's norms. I'm happy to hand it over after it is accepted. Your call — I just figured it would be natural ;) Cheers Sascha
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail