On Fri, Apr 22, 2016 at 11:14:16AM +0200, Julien Lamy wrote:
>
>
> Le 22/04/2016 08:42, Ghislain Vaillant a écrit :
> > On 22/04/16 07:03, Julien Lamy wrote:
> >> It seems that my fix actually made things worse since the builds have
> >> failed for almost all architectures [1]. I think the cause is me not
> >> reading correctly pbuilder's man page and build testing my previous
> >> version with "--debbuildopts -B" instead of "--binary-arch". I've
> >> committed a new version, with a better separation of arch and indep in
> >> d/rules [2]. I've checked that "pbuilder --debbuildopts -A" builds only
> >> indep packages, that "pbuilder --binary-arch" build only arch packages
> >> and that packages are usable.
> >>
> >> Does this new version seem correct ? Are there other tests to run than
> >> my pbuilder ones ?
> >>
> >> Sorry for the noise !
> >>
> >> [1] https://buildd.debian.org/status/package.php?p=odil
> >> [2] https://anonscm.debian.org/cgit/debian-med/odil.git/commit/
> >>
> >> Cheers,
> >
> > Hey Julien,
> >
> > Indeed if you want to achieve true separation between -arch and -indep
> > only builds, then the additional overrides you listed with a no-op in it
> > are required.
> >
> > This however:
> > +override_dh_auto_build-arch:
> > dh_auto_build
> >
> > ...should not be needed I believe.
>
> You're right, it is not necessary. With the latest commit, I think the
> package is now ready for a new upload (full/arch/indep builds OK,
> lintian OK).
I can do it this day.
Have you really tested that `dpkg-buildpackage -B` (what is done on
arch-dep builds in buildds) and `dpkg-buildpackage -A` (for the -indep)
work as expected?
I'm going to test them out, and check if that works as expected, if not,
well, I'll try to have it working :) (hope you're ok with it)
From a quick glance on git, to me it seems that you forgot about the
override_dh_configure override (as you don't want it for -indep, but you
do for -arch).
Also, it would imho be nice to have Build-Depends splitted on
Build-Depends-Arch too, but the support for it is pretty limited, and
only 5 packages in the whole archive currently use it, so maybe this is
not something to care about now :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature