On 22/08/15 13:25, Fabian Klötzl wrote: > Hi, > > Am 22.08.2015 um 12:28 schrieb Tomasz Buchert: > > I've pushed another change to libdivsufsort which, to my knowledge, > > is "The Right Thing To Do". I still needed to apply a custom patch > > for "include" directory because header files are generated > > on-the-fly, but other than that it seems fine. > > Patch looks ok to me, but I am not an expert on these things. Hi, I did it according to the bug I mentioned. It is supposed to work even when cross-compiling, but I didn't check it. > > > I propose to ask upstream to use them. > > Definitely, once we have the patches ready, they should be bundled in > a pull request. Then we should notify upstream via mail, because they > don't seem to be an active GitHub user. > > With respect to bug #794729. I guess that is fixed now and can be > closed. But since libdivsufsort-dev now depends on libdivsufsort3 > should we also add the 3 to the -dev package: libdivsufsort3-dev? What > is the usual debian way to handle that? The usual way is to have libdivsufsort-dev. Wrt the bug: as the dependency is now explicit, you can close in the next release. More genrally, you need to format the changelog with a nice summary of all changes. > > Best, > Fabian > Cheers, Tomasz
Attachment:
signature.asc
Description: Digital signature