[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: snpomatic



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Andreas,

> thanks for working on it.  I hope upstream will follow your request
> to add proper versioning.

So do I, let's see how things develop.

> I uploaded to new but would like to mention the minor nitpicking
> that
> 
> debian/patches/fix_ungap
> 
> has lots of patch chunks that are just removing space which makes 
> reading to the real content of the patch a bit nasty.

True. In general I consider trailing whitespace something to be
removed wherever encountered, but if you reckon that people will be
re-reading the patch I am happy to oblige ;)

> I'd recommend removing these spacing-changing chunks in a next 
> version of the package.

Sure, no problem at all.

Thanks for the upload,
Sascha

> On Mon, Dec 14, 2015 at 03:46:16PM +0000, Sascha Steinbiss wrote: 
> Hi all,
> 
> I have prepared snpomatic as a dependency for REAPR (to come). I
> would be happy if someone could take a look in git. Apart from the
> missing watch file (no releases tagged by upstream) it is lintian
> clean and builds reproducibly. Looking forward to your comments!
> 
> Thanks Sascha
>> 
>> 
>> -- The Wellcome Trust Sanger Institute is operated by Genome
>> Research Limited, a charity registered in England with number
>> 1021457 and a company registered in England with number 2742969,
>> whose registered office is 215 Euston Road, London, NW1 2BE.
>> 
>> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWbvXuAAoJEFVWo04Eo2ELbYYQALM3K6ZK+kRe2DqI7uTbjo4B
xz+b9Hno86FeeZb49MGxO+9bag5NDjTrxdbtaEoiGlUA8RNORlyAoSxYTnl4SmOc
0kef6lPqGVAaBg2h+QdfvohVj26X7wbz0B1B19PHHLlWDSgl3REZnCIgOTITJMWe
ps73DqLuNO6TEOnlgZM7UFzo00lObHIGzT93XisLwEY090eLkG17qevQ6WujF0DU
eN+d5sA0/MKGxV+F419MrtBAxyevYE/UMXvg0d5JHYwkMOc7PDgo7Q0aMjhP1yZm
pjTrxpAi0rJWeKgeYRgvNEpy7ys2vpwwBNAIvNfQsi8BmEA07v5E0p+gzbw8LjAv
a9Qu32HyeutKMvpo6fYe0v3J2jftN3yEgfn4Y2xl5NCDx07xp0OfQq/wmo/orv2t
6LH5BTPzHdxa/GsGXn4D4sr0hsNeg+HplAUNoLzqfDfa5Qz6yQt+Qb8mR4fnxuaU
od67pcmOfBKpwNCBhNRG9M8Ue/81xeqn6cJurXON4Diuh7G3dQVHJKRdha3zZo2T
aPv/DIBhZHUgFOS+Dr3MeQ60o9mD1oiOdPACXCQjJmnYqf3Fq1LCdXeaDDzsLTcZ
HVXTkwhIuwAHVTxROYO3gSaiCW0C01HUJ+8U6Jmc5ZV6I+xrsFwz/ZhuxCXqUhj9
FKQZ5DTfWQalnbSLupc4
=ybaU
-----END PGP SIGNATURE-----


-- 
 The Wellcome Trust Sanger Institute is operated by Genome Research 
 Limited, a charity registered in England with number 1021457 and a 
 company registered in England with number 2742969, whose registered 
 office is 215 Euston Road, London, NW1 2BE. 


Reply to: