[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: python-pysam



Hi, Andreas,

On الخميس 25 حزيران 2015 09:50, Afif Elghraoui wrote:
Hi, Andreas,
Please excuse the top-posting reply format from my phone...I don't know if I'll get to my development machine today.

There are two issues. One is that I think there are other files missing a copyright declaration besides htslib. This must be checked before any upload so we don't get it rejected again.

The other thing is that the python3 teats are failing due to some apparent 2-3 incompatibility in the test runner script. I couldn't properly test the python2 package due to some misconfiguration of adt, so I don't know how that fares. If you consider this polishing, then maybe we can leave this off for after the ftpmaster's review.

regards
Afif

بتاريخ ٢٥‏/٠٦‏/٢٠١٥ ١:٥٠ ص، جاء من Andreas Tille <andreas@an3as.eu>:

Just let me know if you are ready and I'll upload as soon as possible.


Ok. Just to let you know, the next chance I will have to work on this likely
won't be until this weekend.


I ended up getting a chance today. I heavily modified the copyright file and I think it is ready enough to go back to the ftpmaster for review. Please upload to unstable or experimental at your discretion based on the potential problem I mentioned before about getting the tests to run.



After pulling your last commits and fixing a minor lintian issue in
d/watch from my point of view the package builds nicely without lintian
issues and the problem claimed by ftpmaster is solved.  So from my point
of view the package looks ready.  I have no idea what you intended to do
on the package but may be it is sensible to upload it now since it might
need another 1-3 days to be processed.  If some polishing is left this
can be done with an upload that makes it to unstable straigth.  If there
are some known issues I could also upload to experimental.


Regards
Afif


Reply to: