[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Plastimatch ready for upload



Dear Andreas,

> 
> On Mon, May 04, 2015 at 07:27:12PM -0400, Gregory Sharp wrote:
> > > Could you please explain your motivation to do the package that way?
> > 
> > This was not intentional, therefore an error.  Thank you for finding!
> > I believe that I could fix by modifying the rules file.
> 
> I noticed that you actually fixed it by modifying d/rules.  I added this
> change to d/changelog and uploaded. 
> 
> In any case I need to say that I have some bad feelings about the code
> copy of Lua inside plastimatch and the delivered patches for itk are
> something that should be avoided in the long run.  I'm just telling you
> this as upstream developer - may be you might get some solution for this
> in one of your next releases.

So far, I could fix the following issues:

- fix regression test failure on i386
- use shared library build for debian package
- remove patched version of lua

The one I couldn't solve was to remove the patched ITK files. 
The patch is still relevant for the less popular platforms 
where ITK4 is not available.

Thank you,
Greg


Reply to: