[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] Unit tests for Camp



Hi Corentin,

On Wed, Sep 10, 2014 at 04:22:42PM +0200, Corentin Desfarges wrote:
> Hi Andreas,
> 
> 
> About the unit tests for Camp, can you tell me what do you think about this patch (to add at d/patches)
> 
> --- a/cmake/Config.cmake
> +++ b/cmake/Config.cmake
> @@ -20,16 +20,16 @@
>      )
>  endif()
> -# Set the default test build option to false
> +# Set the default test build option to true
>  if(NOT BUILD_TEST)
> -    set(BUILD_TEST FALSE
> +    set(BUILD_TEST TRUE
>          CACHE BOOL "TRUE to build the unit tests (requires the Boost Test Library), FALSE otherwise."
>      )
>  endif()
> -# Set the default test build option to false
> +# Set the default test build option to true
>  if(NOT BUILD_TEST_QT)
> -    set(BUILD_TEST_QT FALSE
> +    set(BUILD_TEST_QT TRUE
>          CACHE BOOL "TRUE to build the Qt-specific unit tests (requires the Boost Test Library and Qt 4.5), FALSE otherwise."
>      )
>  endif()

Just from reading (= without testing) this sounds perfectly fine and was
my first thought (which I forgot later when trying to add the CMAKE
option to d/rules.  I'd say go for it if it works.
 
> And for the d/control:
> 
> diff --git a/debian/control b/debian/control
> index d43930f..afb332b 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -4,7 +4,9 @@ Section: science
>  Priority: optional
>  Build-Depends: cmake,
>                 debhelper (>= 9),
> +               libboost-dev,
> +               libboost-test-dev,
> +               libqt4-dev
>  Standards-Version: 3.9.5

I somehow expected that some extra QT libs would be needed to run the
full test suite.
 
> That permits to launch the unit tests build, but they are not executed...
> (Qt4 is required for the unit tests too)
> 
> Have you any idea ?

May be you need to find out what command might trigger the test suite and
force this via

   override_dh_auto_test

Hope this helps

        Andreas. 

-- 
http://fam-tille.de


Reply to: