On 10-12-13 19:23, Andreas Tille wrote:
> On Tue, Dec 10, 2013 at 03:09:46PM +0100, L.C. Karssen wrote:
>
>>> override_dh_installdocs:
>>> dh_installdocs
>>> find debian -name INSTALL -delete
>>> rm -f debian/$(DEBPKGNAME)/usr/share/doc/$(DEBPKGNAME)/COPYING
>>> <whatever method to remove you prefer>/LICENSE
>>>
>>> Just pick your favourite method to remove the files manually.
>>
>> Thanks, that cleared things up for me. As to the question below, as you
>> say, this is solved by your suggestions.
>
> Please note: I'd always recommend to use "rm -f". The rationale is
> that upstream might either stop installing a file (like INSTALL - which
> is actually stupid to install since the user has passed this step at
> this time and it becomes redundant) or rename a file and this will break
> your build process if the file you try to remove is not there. You
> might argue that you actually want it to break to notice the change which
> is fine - just take this as recommendation.
>
I'll stick with plain rm, because, as you pointed out, I'd like to know
something is broken if the file is removed/renamed upstream.
>>>> Also, in order to fix the name of the ChangeLog.gz file to changelog.gz
>>>> I tried adding
>>>>
>>>> mv usr/share/doc/probabel/{ChangeLog,changelog}.gz
>
> I have seen this push now and I see that you have really choosen this
> syntax. Without trying this looks like a bashism and in fact when using
> pbuilder (see below) - which has a minimal chroot and thus no bash -
> this fails with
>
> mv: missing destination file operand after 'debian/probabel/usr/share/doc/probabel/{ChangeLog,changelog}'
> Try 'mv --help' for more information.
>
Indeed, that's me trying to be quick; it's a bashism.
> So the clean solution would be to use
>
> mv debian/$(DEBPKGNAME)/usr/share/doc/${DEBPKGNAME}/ChangeLog \
> debian/$(DEBPKGNAME)/usr/share/doc/${DEBPKGNAME}/changelog
>
> and the very picky solution would be to
>
> rm -f debian/$(DEBPKGNAME)/usr/share/doc/${DEBPKGNAME}/ChangeLog
>
> and use
>
> override_dh_installchangelogs:
> dh_installchangelogs ChangeLog
>
> since this makes clear we are dealing with a changelog here. I do not
> insist on the picky solution - just mentioning it for the sake of
> mentoring.
I like what you call the picky solution. To me it seems the
cleanest/clearest solution.
>
> I guess you will now work down the list of remaining lintian issues.
> Feel free to ask for further advise if needed.
Yup, that's what I plan to do. These are the warning that remain:
1) W: probabel: new-package-should-close-itp-bug
This one we/you fix when the package is ready for submission, right?
2) 2x W: probabel: script-with-language-extension
This is something we discuss upstream. One of them can be fixed
relatively easily, I think. The other one may interfere too much with
what users currently expect/existing workflows. My feeling is that
removing the extension will require a major version jump and good
communication with the users/their sysadmins.
3) 2x W: probabel: binary-without-manpage
This I can fix quite easily. I see two solutions:
a) fix this in the Debian package ("Here")
b) fix this upstream in the imminent v0.4.2 release
To me option b) sounds the easiest, but option a) may be more
illustrative in light of our MoM. What do you think?
>
> Regarding pbuilder: There is no need to do all test builds by using
> pbuilder (or cowbuilder which is a faster pbuilder so to say) but I
> upload all packages done in a pbuilder chroot and a package simply needs
> to build there to make sure it will be buildable in our autobuilders
> farm. So it is a good idea if you become comfortable with this
> principle a bit.
Good point. I was being lazy and used debuild, because I couldn't get
DEB_BUILD_OPTIONS="parallel=4"
passed to/accepted by pbuilder. I'll make sure I run pbuilder at least
once before committing.
>
> I'm quite happy about the progress you are taking
Thanks! And my compliments to you for the good and quick advice along
the way.
Lennart.
>
> Andreas.
>
--
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
L.C. Karssen
Utrecht
The Netherlands
lennart@karssen.org
http://blog.karssen.org
GPG key ID: A88F554A
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-
Attachment:
signature.asc
Description: OpenPGP digital signature