Re: Uploading Praat 3.5.35-1
On Wed, Dec 12, 2012 at 12:59:23PM +0100, Rafael Laboissiere wrote:
> >I do not think that appending CFLAGS/CXXFLAGS instead of
> >overriding or respecting LDFLAGS is anyhow Debian specific but
> >rather good Makefile practice.
>
> I agree.
>
> Just one question, since you are the author of the quilt patch
> use-dpkg-buildflags.patch: what is the rationale for appending the
> variables CFLAGS and CXXFLAGS?
I simply wanted to be very sure that it works and both variables were
used in the Makefile. Just following the principle I stated above that
I do not consider plain overriding of such a variable is good style I
enabled adding to both. Most probably it is enough to feed only one of
these (do not remember by heart which one) with the fortifying options.
I do not mind if you pick one of these if it works afterwards as
expected.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: