Re: Any progress with FIS GT.M?
responses as [amul:2]
On 07/02/12 22:44, Yaroslav Halchenko wrote:
> On Mon, 02 Jul 2012, Luis Ibanez wrote:
>> yeap -- all executables scripts must have shebang to guarantee proper
>> environment to be chosen.
>> I'm now inserting the shebang line in the "rules" file, by calling sed.
>> It is not pretty, but it does the trick.
> I would strongly recommend just to do these changes in upstream
> repository so they become a part of upcoming fresh "orig" tarball. If
> those scripts are POSIX-shell compliant (e.g. with dash which is default
> /bin/sh on Debian systems) -- use #!/bin/sh. If they require bash --
> #!/bin/bash (which might be a safer choice altogether).
>
>> Note that, after the change, one of the scripts get a format warning
>> from lintian. (must still track that one: +1 in my TODO list).
> ;-) just change in upstream sources -- any objections Amul?
[amul:2] For the moment we'll change the upstream GIT
repo. We may have to maintain this as a patch until I
learn why the scripts don't have the shebang. I'm
guessing at least one of our supported platforms forced
us to make the files this way.
[amul:2] Going back to the original list, these are shell
env and configuration files:
> W: fis-gtm source: newer-standards-version 3.9.3 (current is 3.9.1)
> W: fis-gtm-5.5.000: executable-not-elf-or-script ./usr/lib/fis-gtm/V5.5-000_x86_64/gtmprofile
> W: fis-gtm-5.5.000: executable-not-elf-or-script ./usr/lib/fis-gtm/V5.5-000_x86_64/gtmprofile_preV54000
> W: fis-gtm-5.5.000: executable-not-elf-or-script ./usr/lib/fis-gtm/V5.5-000_x86_64/gtmcshrc
> W: fis-gtm-5.5.000: executable-not-elf-or-script ./usr/lib/fis-gtm/V5.5-000_x86_64/gtcm_slist
[amul:2] These are actual scripts that need the shebang.
> W: fis-gtm-5.5.000: executable-not-elf-or-script ./usr/lib/fis-gtm/V5.5-000_x86_64/gtmstart
> W: fis-gtm-5.5.000: executable-not-elf-or-script ./usr/lib/fis-gtm/V5.5-000_x86_64/gtcm_run
> W: fis-gtm-5.5.000: executable-not-elf-or-script ./usr/lib/fis-gtm/V5.5-000_x86_64/gtmstop
>> if they are to be sourced they should not be executable... we might
>> altogether place them under /etc/fis-gtm/5.5.000/ since they sound like
>> environment configuration files. Are they supposed to be sourced by any
>> fis-gtm's script? then we might like to symlink them back under
>> /usr/lib/fis-gtm/V5.5-000_x86_64/
>> This is a question for Bhaskar.
>> The implications escape me... :-)
> there should be none (unless there is some obscure readlink -f logic
> inside ;) )
[amul:2] Seems fair enough to me. However, Bhaskar
has more experience with VistA deployments and
may offer a better suggestion when he is back from
vacation.
>
>> most probably. if no internal scripts/binaries rely on it to be there:
>> rm after installation (in debian/rules). If they are needed -- lintian
>> override is needed with a description for that
>> I used the dictatorial method of deleting the COPYING file
>> with an entry in the rules file. Another non-pretty solution,
>> but yet one that does the trick...
> that one is how I would do it -- so must be correct! ;)
>
>> > >W: fis-gtm-5.5.000: shlib-with-executable-stack
>> usr/lib/fis-gtm/V5.5-000_x86_64/libgtmshr.so
>> > [amul:1] This is expected. Ignore it
>> weird -- that should have been ignored since I added creation of an
>> override in debian/rules... may be that old lintian did not understand
>> the '*' in the file pattern... test with a fresh one
>> I'll post the outputs of a fresh build.
> I hope we could avoid that ;) (i.e. it would just work ;) )
>
>
>> This step resets permissions to safe defaults.
>> In our case, we have to override the default behavior
>> of this stage, in order to prevent it from changing the
>> permissions that we have set correctly in the intermediate
>> installation.
>> Is that right ?
> sounds correct
>
>
_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
Reply to: