Re: FreeDiams

[Andreas Tille <andreas@fam-tille.de>]

Hi Eric,

I had another look into FreeDiams and I would like to propose some
changes for your upstream tarball which will turn out to be very helpful
for every Linux user and specifically for clean Debian packaging.

  1. Please make only those files executable which really are
     intended to be executed.  I only found one single file
     which should be executable: updatetranslations.sh

     So I would suggest to do

       find . -type f -exec chmod 644 \{\} \;

     which makes all files readable for everybody and writable
     for the user.  After this reset executable flag for the script

       chmod 755 updatetranslations.sh

     This change in your tarball makes sure we will not have to
     fix permissions of files while building the Debireadable for everybody and writable
     for the user.  After this reset executable flag for the script

       chmod 755 updatetranslations.sh

     This change in your tarball makes sure we will not have to
     fix permissions of files while building the Debiareadable for everybody and writable
     for the user.  After this reset executable flag for the script

       chmod 755 updatetranslations.sh

     This change in your tarball makes sure we will not have to
     fix permissions of files while building the Debian package.

  2. Use an upstream changelog: 

On Fri, Oct 23, 2009 at 08:56:05PM +0200, Eric MAEKER wrote:
>
> Ok so the changelog in debian dir must only inform new uploads (and  
> changes done to the other debian files).

     So if I would be in your shoes I would just move the
     debian/changelog to ChangeLog.  Once this is done we can
     use a quite simple changelog saying something like

freediams (0.1.5-1) unstable; urgency=low

  * Initial upload (Closes #<ITPbug>)

 -- Uploader / Date

     This makes things much easier and transparent for Debian users
     and your fellow developers

  3. Please fix the clean target of your makefile.  I had to use the
     following tweak in the debian/rules file:

override_dh_auto_clean:
        rm -rf bin/plugins/* bin/freediams
        find build -type d -name "\.*" -exec rm -rf \{\} \; 2> /dev/null || true
        rm -rf global_resources/doc/FreeDiams

     It would be great, if you would add these three lines to your
     clean target.

Please let me know if you agree with these suggestions and if yes, when you
might release a new tarball addressing these items.

Kind regards

      Andreas.

-- 
http://fam-tille.de