[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch rule in debian/rules.



On Fri, 19 Sep 2008 11:29:16 +0200, Michael Banck wrote:

> On Fri, Sep 19, 2008 at 01:41:13PM +0900, Charles Plessy wrote:
> > here is a mail explaining that many of our debian/rules files are
> > suboptimal. I will update our group policy and apply changes where
> > necessary. But do not hesitate to do it before I start ;)
>  
> > QUILT_STAMPFN = quilt-stamp
> > 
> > $(QUILT_STAMPFN):
> >         touch $@
> > 
> > patch: $(QUILT_STAMPFN)
> > 
> > build: build-stamp
> > build-stamp: $(QUILT_STAMPFN)
> 
> Personally, I'd rather keep implementation details like quilt out of
> debian/rules target names, and call that stampfile build-stamp is
> depending upon "patch-stamp" rather than "quilt-stamp" (via
> $(QUILT_STAMPFN)).

That was an example debian/rules causing problems.
IMHO, the correct way is:

---8<---
include /usr/share/quilt/quilt.make

configure: configure-stamp
configure-stamp: $(QUILT_STAMPFN)
	...

build: build-stamp
build-stamp: configure-stamp
	...
--->8---

Kindly,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature


Reply to: