Re: RFS: emboss-explorer
Hi!
On 5/12/07, Andreas Tille <tillea@rki.de> wrote:
On Sat, 12 May 2007, David Paleino wrote:
> Would any DD following the list please take a look at it?
I could have a look but I guess it is more reasonable if the same
person who uploaded Emboss would have a look onto it instead of
me as a person who never even started Emboss.
$ who-uploads emboss
Uploads for emboss:
4.1.0-1 to experimental: Nelson A. de Oliveira <naoliv@debian.org>
Bah! He has the same name as me! :-)
David, your package fails to build:
(...)
perl Makefile.PL INSTALLDIRS=vendor
Checking if your kit is complete...
Looks good
MakeMaker FATAL: prerequisites not found (Mail::Send not installed,
Parse::RecDescent not installed)
Please install these modules first and rerun 'perl Makefile.PL'.
make: *** [build] Error 2
Including libparse-recdescent-perl and libmailtools-perl on
Build-Depends fix this.
Still on debian/control. I think that it's not necessary the versioned
build-dep on perl, since we already have perl >= 5.6.0-16 since Sarge
(version 5.8.x). Unstable version is 5.8.8-7
Also, since it's a web application, shouldn't it depends, or at least
recommends, a HTTP server?
(README.Debian says "Visit http://localhost/cgi-bin/emboss to test
EMBOSS." but without a server we can't do this)
Do it works without emboss? (has it some functionality that doesn't
need emboss?) I am asking this because emboss is just recommend (raise
to depends?)
And some (more) doubts on README.Debian:
How secure is to run the cron as root? Can't it be run with a less
privileged user? (if yes, then it's better on my opinion)
These lines:
Please report any errors or strange occurrences using the bug tracker at
http://sourceforge.net/tracker/?func=add&group_id=124389&atid=699414
Can't they make the user think that he/she needs to report the bug to
the Emboss explorer BTS, even the ones related with Debian only?
(Could be possible to some users understand that they should report
_all_ bugs to the SF BTS, right?)
I would remove this line and let them report the issues directly to
the Debian BTS. If necessary, forward it to upstream authors.
You have repackaged the original source code, but it's not necessary to do this.
Copy the debian/ dir inside emboss-explorer/, rename the original
emboss-explorer-2.2.0.tar.gz to emboss-explorer_2.2.0.orig.tar.gz and
you will see that the package will be built normally, without
problems. dpkg-source (if I remember correctly) can handle this,
without the need to add the version to the dir and create a new
.tar.gz file.
On debian/copyright you say that the program is released under the
Artistic License, but I see on README that it has the same terms of
Perl.
Perl's README says that it can be distributed under GNU GPL or under
the Artistic License. (needs to update the copyright file, like Perl's
copyright).
Maybe Charles can say something else, since he is the guy who plays
with Emboss :-)
Best regards,
Nelson
Reply to: