[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ITP:dcmtk looking for sponsor



* Pablo Sau <psau@cadpet.es> [041105 17:46]:

> http://sourceforge.net/project/showfiles.php?group_id=61662

Pablo,

thank you for your work. Just a one or two comments:

It it not sufficient to install dicom.dic in /usr/lib/ instead of 
it's default location beneath /usr/local/dicom/lib. You'll 
also have to adjust DCM_DICT_DEFAULT_PATH in config/configure.in 
to make the applications become aware of the new location. 

I also think that, according to the Unix Filesystem Hierarchy Standard
(see e.g. http://www.pathname.com/fhs/) it's natural place would
be beneath /usr/share/dcmtk since dicom.dic contains read-only 
architecture independent data.

Recently, I had a discussion about these issues with Joerg
at comp.protocols.dicom and it seems Offis team is going to 
fix this in the next release.
 
In the meantime, I'd suggest the following patch to fix the 
DCM_DICT_DEFAULT_PATH problem. (Don't forget to run config/autoall 
afterwards to make the configure script reflect the changes.)

You should then add --datadir=/usr/share/dcmtk to your configure
options.

Thanks again for your excellent work.

Best regards - Juergen

--- dcmtk-3.5.3.orig/config/configure.in
+++ dcmtk-3.5.3/config/configure.in
@@ -29,10 +29,13 @@
 
 if test "x$prefix" = xNONE ; then
 AC_DEFINE_UNQUOTED(DCMTK_PREFIX, "${ac_default_prefix}", [Define the DCMTK default path])
+eval dcm_dict="${ac_default_prefix}/lib/dicom.dic"
 else
 AC_DEFINE_UNQUOTED(DCMTK_PREFIX, "${prefix}", [Define the DCMTK default path])
+eval dcm_dict="${datadir}/dicom.dic"
 fi
-AC_DEFINE_UNQUOTED(DCM_DICT_DEFAULT_PATH, DCMTK_PREFIX "/lib/dicom.dic", [Define the default data dictionary path for the dcmdata library package])
+
+AC_DEFINE_UNQUOTED(DCM_DICT_DEFAULT_PATH, "${dcm_dict}", [Define the default data dictionary path for the dcmdata library package])

-- 
GPG A997BA7A | 87FC DA31 5F00 C885 0DC3  E28F BD0D 4B33 A997 BA7A

Attachment: signature.asc
Description: Digital signature


Reply to: